You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/17 11:51:26 UTC

[GitHub] [hudi] harsh1231 opened a new pull request #4838: Fix HoodieIncr source checkpoint not progressing

harsh1231 opened a new pull request #4838:
URL: https://github.com/apache/hudi/pull/4838


   … drop / cast columns
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4838: Fix HoodieIncr source checkpoint not progressing

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#issuecomment-1042875104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6094",
       "triggerID" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b73b873d9d4da5769a05a3006287e58a97a8d5e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6094) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] harsh1231 commented on a change in pull request #4838: Fix HoodieIncr source checkpoint not progressing

Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#discussion_r808978732



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -174,7 +178,27 @@ public S3EventsHoodieIncrSource(
     }
     Option<Dataset<Row>> dataset = Option.empty();
     if (!cloudFiles.isEmpty()) {
+      Log.info("Number of files to be processed=" + cloudFiles.size());
       dataset = Option.of(sparkSession.read().format(fileFormat).load(cloudFiles.toArray(new String[0])));
+      if (props.containsKey(HoodieIncrSource.Config.DROP_COLUMNS)) {
+        String dropColumns = props.getString(HoodieIncrSource.Config.DROP_COLUMNS);
+        dataset = dataset.map(ds -> ds.drop(dropColumns.split(",")));
+      }
+      if (props.containsKey(HoodieIncrSource.Config.CAST_TO_STRING)) {

Review comment:
       Okay 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4838: Fix HoodieIncr source checkpoint not progressing

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#issuecomment-1042875104


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6094",
       "triggerID" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b73b873d9d4da5769a05a3006287e58a97a8d5e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6094) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot removed a comment on pull request #4838: Fix HoodieIncr source checkpoint not progressing

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#issuecomment-1042872697


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b73b873d9d4da5769a05a3006287e58a97a8d5e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on a change in pull request #4838: Fix HoodieIncr source checkpoint not progressing

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on a change in pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#discussion_r808974095



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -106,8 +110,8 @@ public S3EventsHoodieIncrSource(
             sparkContext, srcPath, numInstantsPerFetch, beginInstant, missingCheckpointStrategy);
 
     if (queryTypeAndInstantEndpts.getValue().getKey().equals(queryTypeAndInstantEndpts.getValue().getValue())) {
-      LOG.warn("Already caught up. Begin Checkpoint was :" + queryTypeAndInstantEndpts.getKey());
-      return Pair.of(Option.empty(), queryTypeAndInstantEndpts.getKey());
+      LOG.warn("Already caught up. Begin Checkpoint was :" + queryTypeAndInstantEndpts.getValue().getKey());

Review comment:
       probably we can make this a separate PR and add tests. I can take it up if need be. Can you remove that from this PR.  

##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/S3EventsHoodieIncrSource.java
##########
@@ -174,7 +178,27 @@ public S3EventsHoodieIncrSource(
     }
     Option<Dataset<Row>> dataset = Option.empty();
     if (!cloudFiles.isEmpty()) {
+      Log.info("Number of files to be processed=" + cloudFiles.size());
       dataset = Option.of(sparkSession.read().format(fileFormat).load(cloudFiles.toArray(new String[0])));
+      if (props.containsKey(HoodieIncrSource.Config.DROP_COLUMNS)) {
+        String dropColumns = props.getString(HoodieIncrSource.Config.DROP_COLUMNS);
+        dataset = dataset.map(ds -> ds.drop(dropColumns.split(",")));
+      }
+      if (props.containsKey(HoodieIncrSource.Config.CAST_TO_STRING)) {

Review comment:
       in general this should go in as a general feature support to any detlastreamer sources. Lets think about what it takes to add such feature. If its not feasible, we can add it just incr source. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4838: Fix HoodieIncr source checkpoint not progressing

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#issuecomment-1042872697


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b73b873d9d4da5769a05a3006287e58a97a8d5e UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] hudi-bot commented on pull request #4838: Fix HoodieIncr source checkpoint not progressing

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#issuecomment-1042972035


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6094",
       "triggerID" : "0b73b873d9d4da5769a05a3006287e58a97a8d5e",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 0b73b873d9d4da5769a05a3006287e58a97a8d5e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=6094) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] nsivabalan commented on pull request #4838: [WIP] Adding support to casting array and struct cols to string in S3 incr source

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #4838:
URL: https://github.com/apache/hudi/pull/4838#issuecomment-1054448537


   @harsh1231 : once you have the patch ready (either same one, or new ones), do let me know. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org