You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by dalaro <gi...@git.apache.org> on 2017/05/27 01:47:41 UTC
[GitHub] tinkerpop pull request #616: TINKERPOP-1680 Add string performance options t...
GitHub user dalaro opened a pull request:
https://github.com/apache/tinkerpop/pull/616
TINKERPOP-1680 Add string performance options to StarGraph
By default, StarGraph invokes intern() on vertex label and property
key strings. It also toString()s vertex and edge IDs for comparisons
and existence checks.
This commit introduces a new StarGraph builder with a pair of boolean
options controlling these behaviors.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dalaro/incubator-tinkerpop TINKERPOP-1680
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/616.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #616
----
commit 0155665162668f68713bc4fe5a95678a6905c72b
Author: Dan LaRocque <da...@hopcount.org>
Date: 2017-04-04T23:41:29Z
TINKERPOP-1680 Add string performance options to StarGraph
By default, StarGraph invokes intern() on vertex label and property
key strings. It also toString()s vertex and edge IDs for comparisons
and existence checks.
This commit introduces a new StarGraph builder with a pair of boolean
options controlling these behaviors.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/616
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #616: TINKERPOP-1680 Add string performance options t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/616
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/616
@dalaro when i build this branch i get some errors (they pop up intermittently in integration tests and not in all environments) that i long ago thought i took care of. is it possible that the branch in your fork needs to be rebased on the latest stuff from tp32?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/616
All good now after the rebase. All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/616
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...
Posted by dalaro <gi...@git.apache.org>.
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/616
I force-pushed this PR's branch. The new basis is 4f7b8595bbcd691649e63e49deb9ed0adcaa81e7 (May 28).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #616: TINKERPOP-1680 Add string performance options to StarG...
Posted by dalaro <gi...@git.apache.org>.
Github user dalaro commented on the issue:
https://github.com/apache/tinkerpop/pull/616
@spmallette maybe -- basis of the PR branch is b755788c6fe7b902a3e81f3c2f11eb5a8b02c4be (May 11). I'll rebase on latest tp32 and force-push the PR branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---