You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/18 01:26:54 UTC

[GitHub] [airflow] uranusjr commented on a change in pull request #19034: Fix ``None`` default Param; refactor Param default handling

uranusjr commented on a change in pull request #19034:
URL: https://github.com/apache/airflow/pull/19034#discussion_r730514702



##########
File path: airflow/models/param.py
##########
@@ -24,6 +24,16 @@
 from airflow.exceptions import AirflowException
 
 
+class NoValueSentinel:

Review comment:
       I think we now have like five different sentinel class implementations in the code base. I have one for `DAG(schedule_interval)`. Probably should unify them somewhat into `airflow.utils.types` at some point.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org