You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/14 03:25:00 UTC
[jira] [Commented] (GROOVY-8234) Add @Repeatable java8 annotation
support
[ https://issues.apache.org/jira/browse/GROOVY-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086787#comment-16086787 ]
ASF GitHub Bot commented on GROOVY-8234:
----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/567
> Add @Repeatable java8 annotation support
> ----------------------------------------
>
> Key: GROOVY-8234
> URL: https://issues.apache.org/jira/browse/GROOVY-8234
> Project: Groovy
> Issue Type: New Feature
> Environment: groovy 2.4.11
> Reporter: Dmitry Lukyanov
>
> raised on stackoverflow: https://stackoverflow.com/questions/44532632/is-the-repeatable-annotation-not-supported-by-groovy/44628119#44628119
> Problem: the following code in groovy 2.4.11 / java8
> {code}
> @MyAnnotation(value = "val1")
> @MyAnnotation(value = "val2")
> void annotatedMethod() { println("annotated method called") }
> {code}
> should be compiled to this:
> {code}
> @MyAnnotationArray({@MyAnnotation("val1"), @MyAnnotation("val2")})
> void annotatedMethod() { println("annotated method called") }
> {code}
> but actually compiled to this:
> {code}
> @MyAnnotation(value = "val1")
> @MyAnnotation(value = "val2")
> void annotatedMethod() { println("annotated method called") }
> {code}
> The full groovy script to reproduce problem is below.
> It throws exception:
> {color:red}java.lang.annotation.AnnotationFormatError: Duplicate annotation for class: interface MyAnnotation: @MyAnnotation(value=val2){color}
> at line `List annos = m.getAnnotations()`
> {code}
> import java.lang.annotation.*
> class MyClass
> {
> @MyAnnotation(value = "val1")
> @MyAnnotation(value = "val2")
> //change annotation to next line and the code will work
> //@MyAnnotationArray( [@MyAnnotation("val1"), @MyAnnotation("val2")] )
> public void annotatedMethod()
> {
> System.out.println("annotated method called");
> }
> public static void main(String... args)
> {
> MyClass ob = new MyClass()
> ob.annotatedMethod()
> java.lang.reflect.Method m = ob.getClass().getMethod("annotatedMethod")
> List annos = m.getAnnotations()
> println("annos = $annos")
> }
> }
> @Target(ElementType.METHOD)
> @Retention(RetentionPolicy.RUNTIME)
> @Repeatable(MyAnnotationArray)
> public @interface MyAnnotation
> {
> String value() default "val0";
> }
> @Retention(RetentionPolicy.RUNTIME)
> public @interface MyAnnotationArray
> {
> MyAnnotation[] value()
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)