You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by kr...@apache.org on 2022/09/06 14:26:56 UTC
[solr] branch branch_9x updated: SOLR-16399: ExportWriter fails with max values for fields (#995)
This is an automated email from the ASF dual-hosted git repository.
krisden pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/solr.git
The following commit(s) were added to refs/heads/branch_9x by this push:
new a189eb7f5d5 SOLR-16399: ExportWriter fails with max values for fields (#995)
a189eb7f5d5 is described below
commit a189eb7f5d59d9a74cd5fa298096e3a478f4dc12
Author: Kevin Risden <ri...@users.noreply.github.com>
AuthorDate: Tue Sep 6 10:23:23 2022 -0400
SOLR-16399: ExportWriter fails with max values for fields (#995)
---
solr/CHANGES.txt | 2 ++
solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt
index 0ed5b5358cb..e032ee1270e 100644
--- a/solr/CHANGES.txt
+++ b/solr/CHANGES.txt
@@ -104,6 +104,8 @@ Bug Fixes
* SOLR-16316: Fix debugQuery clicking on the Query UI does not show the debug.explain.structured option. (Shiming Li via Eric Pugh)
+* SOLR-16399: ExportWriter fails with max values for fields (Kevin Risden)
+
Other Changes
---------------------
* SOLR-16351: Upgrade Carrot2 to 4.4.3, upgrade randomizedtesting to 2.8.0. (Dawid Weiss)
diff --git a/solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java b/solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java
index 712bc9b4367..61a76674516 100644
--- a/solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java
+++ b/solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java
@@ -804,7 +804,9 @@ public class ExportWriter implements SolrCore.RawWriter, Closeable {
int docId;
while ((docId = it.nextDoc()) != DocIdSetIterator.NO_MORE_DOCS) {
this.sortDoc.setValues(docId);
- if (top.lessThan(this.sortDoc)) {
+ // Always set the top doc if previously not set, otherwise
+ // set the top if the sortDoc is greater than current
+ if (top.lessThan(this.sortDoc) || top.docId == -1) {
top.setValues(this.sortDoc);
top = queue.updateTop();
}