[GitHub] [parquet-mr] gszadovszky commented on a change in pull request #856: PARQUET-1964: Properly handle missing/null filter

[GitBox <gi...@apache.org>]

gszadovszky commented on a change in pull request #856:
URL: https://github.com/apache/parquet-mr/pull/856#discussion_r560992936



##########
File path: parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java
##########
@@ -1046,6 +1046,8 @@ private ColumnIndexStore getColumnIndexStore(int blockIndex) {
   }
 
   private RowRanges getRowRanges(int blockIndex) {
+    assert FilterCompat

Review comment:
       We already test `NOOP` in many places because this one is the default if no filter is present. `null` filter is only possible if the user explicitly set it to `null` in the `ParquetReadOptions`.
   This assert is only to ensure that this private method will not be invoked with a `null` or a `NOOP` filter. No "real" checking is required because the callers are in the same class and they already check the filter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org