You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "somasorosdpc (via GitHub)" <gi...@apache.org> on 2026/03/27 10:48:33 UTC

[PR] FINERACT-2455: Working Capital - Delinquency Classification [fineract]

somasorosdpc opened a new pull request, #5702:
URL: https://github.com/apache/fineract/pull/5702

   ## Description
   
   FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling
   - create SetWorkingCapitalLoanDelinquencyTagsBusinessStep
   -- QA test for business step order
   - create ENABLE_INSTANT_DELINQUENCY_CALCULATION + integration tests
   - Delinquency History for Working Capital Loans
   -- DTOs Entity & Repository
   -- Get API
   -- introduce WorkingCapitalLoanDelinquencyReadPlatformService - for read operations.
   -- Cucumber StepDef + basic tests - WIP


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4141780142

   @somasorosdpc Please rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060221509


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/data/WorkingCapitalLoanCollectionData.java:
##########
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.portfolio.workingcapitalloan.data;
+
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.util.ArrayList;
+import java.util.Collection;
+import lombok.AllArgsConstructor;
+import lombok.Data;
+import org.apache.fineract.portfolio.loanaccount.data.DelinquencyPausePeriod;
+
+@Data
+@AllArgsConstructor
+public class WorkingCapitalLoanCollectionData {
+
+    private Long delinquentDays;
+    private LocalDate delinquentDate;
+    private BigDecimal delinquentAmount;
+
+    public Collection<DelinquencyPausePeriod> delinquencyPausePeriods;

Review Comment:
   List or Set...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4206228942

   @somasorosdpc Still conflicted :( 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060219278


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java:
##########
@@ -186,6 +193,39 @@ public CommandProcessingResult deleteLoanApplication(
         return deleteLoanApplication(null, loanExternalId);
     }
 
+    @GET
+    @Path("{loanId}/delinquencyrangetags")
+    @Consumes({ MediaType.TEXT_HTML, MediaType.APPLICATION_JSON })
+    @Produces(MediaType.APPLICATION_JSON)
+    @Operation(summary = "Retrieve the Loan Delinquency Tag history using the Loan Id", description = "", operationId = "getDelinquencyRangeScheduleTagHistoryById")
+    @ApiResponses({
+            @ApiResponse(responseCode = "200", description = "OK", content = @Content(array = @ArraySchema(schema = @Schema(implementation = WorkingCapitalLoanApiResourceSwagger.GetWorkingCapitalLoanDelinquencyRangeScheduleTagHistoryResponse.class)))) })
+    public Collection<WorkingCapitalLoanDelinquencyTagHistoryData> getDelinquencyRangeScheduleTagHistoryById(

Review Comment:
   Please return List, no Collection...



##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/api/WorkingCapitalLoanApiResource.java:
##########
@@ -186,6 +193,39 @@ public CommandProcessingResult deleteLoanApplication(
         return deleteLoanApplication(null, loanExternalId);
     }
 
+    @GET
+    @Path("{loanId}/delinquencyrangetags")
+    @Consumes({ MediaType.TEXT_HTML, MediaType.APPLICATION_JSON })
+    @Produces(MediaType.APPLICATION_JSON)
+    @Operation(summary = "Retrieve the Loan Delinquency Tag history using the Loan Id", description = "", operationId = "getDelinquencyRangeScheduleTagHistoryById")
+    @ApiResponses({
+            @ApiResponse(responseCode = "200", description = "OK", content = @Content(array = @ArraySchema(schema = @Schema(implementation = WorkingCapitalLoanApiResourceSwagger.GetWorkingCapitalLoanDelinquencyRangeScheduleTagHistoryResponse.class)))) })
+    public Collection<WorkingCapitalLoanDelinquencyTagHistoryData> getDelinquencyRangeScheduleTagHistoryById(
+            @PathParam("loanId") @Parameter(description = "loanId", required = true) final Long loanId, @Context final UriInfo uriInfo) {
+        return getDelinquencyRangeScheduleTagHistory(loanId, null, uriInfo);
+    }
+
+    @GET
+    @Path("external-id/{externalId}/delinquencyrangetags")
+    @Consumes({ MediaType.TEXT_HTML, MediaType.APPLICATION_JSON })
+    @Produces(MediaType.APPLICATION_JSON)
+    @Operation(summary = "Retrieve the Loan Delinquency Tag history using the Loan Id", description = "", operationId = "getDelinquencyRangeScheduleTagHistoryById")
+    @ApiResponses({
+            @ApiResponse(responseCode = "200", description = "OK", content = @Content(array = @ArraySchema(schema = @Schema(implementation = WorkingCapitalLoanApiResourceSwagger.GetWorkingCapitalLoanDelinquencyRangeScheduleTagHistoryResponse.class)))) })
+    public Collection<WorkingCapitalLoanDelinquencyTagHistoryData> getDelinquencyRangeScheduleTagHistoryById(

Review Comment:
   Same as above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4194469395

   @somasorosdpc Please rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060232460


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanDelinquencyReadPlatformService.java:
##########
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.portfolio.workingcapitalloan.service;
+
+import java.time.LocalDate;
+import java.util.Collection;
+import org.apache.fineract.portfolio.workingcapitalloan.data.WorkingCapitalLoanCollectionData;
+import org.apache.fineract.portfolio.workingcapitalloan.data.WorkingCapitalLoanDelinquencyTagHistoryData;
+
+public interface WorkingCapitalLoanDelinquencyReadPlatformService {
+
+    WorkingCapitalLoanCollectionData getCollectionData(Long loanId, LocalDate businessDate);
+
+    Collection<WorkingCapitalLoanDelinquencyTagHistoryData> retrieveDelinquencyRangeScheduleTagHistory(Long loanId);

Review Comment:
   Use `List` please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4213995920

   @somasorosdpc please rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4199201479

   @somasorosdpc Please rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060224775


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/data/WorkingCapitalLoanRangeScheduleDelinquencyData.java:
##########
@@ -0,0 +1,39 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.portfolio.workingcapitalloan.data;
+
+import java.math.BigDecimal;
+import lombok.AllArgsConstructor;
+import lombok.Data;
+
+@Data
+@AllArgsConstructor
+public class WorkingCapitalLoanRangeScheduleDelinquencyData {
+
+    private Long rangeId;
+    private String classification;
+    private Integer minimumAgeDays;
+    private Integer maximumAgeDays;
+    private BigDecimal delinquentAmount;
+
+    public static WorkingCapitalLoanRangeScheduleDelinquencyData template() {
+        return new WorkingCapitalLoanRangeScheduleDelinquencyData(null, null, null, null, BigDecimal.ZERO);

Review Comment:
   Consider using Builder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4199153331

   @somasorosdpc Please rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics merged PR #5702:
URL: https://github.com/apache/fineract/pull/5702


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060207746


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/cob/workingcapitalloan/businessstep/WorkingCapitalLoanDelinquencyClassificationBusinessStep.java:
##########
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.cob.workingcapitalloan.businessstep;
+
+import static org.apache.fineract.infrastructure.core.diagnostics.performance.MeasuringUtil.measure;
+
+import java.util.Optional;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.infrastructure.core.domain.ActionContext;
+import org.apache.fineract.infrastructure.core.domain.ExternalId;
+import org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil;
+import org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoan;
+import org.apache.fineract.portfolio.workingcapitalloan.service.WorkingCapitalLoanDelinquencyClassificationService;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@RequiredArgsConstructor
+@Component
+public class WorkingCapitalLoanDelinquencyClassificationBusinessStep extends WorkingCapitalLoanCOBBusinessStep {
+
+    private final WorkingCapitalLoanDelinquencyClassificationService delinquencyClassificationService;
+
+    @Override
+    public WorkingCapitalLoan execute(WorkingCapitalLoan loan) {
+        if (loan == null) {
+            log.debug("Ignoring Working Capital delinquency tag processing for null loan.");
+            return null;
+        }
+        String externalId = Optional.ofNullable(loan.getExternalId()).map(ExternalId::getValue).orElse(null);
+        measure(() -> setDelinquencyBucketTags(loan, externalId), duration -> {
+            log.debug(
+                    "Ending Working Capital delinquency tag processing for loan with Id [{}], account number [{}], external Id [{}], finished in [{}]ms",
+                    loan.getId(), loan.getAccountNumber(), externalId, duration.toMillis());
+        });
+        return loan;
+    }
+
+    public void setDelinquencyBucketTags(WorkingCapitalLoan loan, String externalId) {
+        try {
+            log.debug(
+                    "Starting Working Capital delinquency tag processing for Working Capital Loan with Id [{}], account number [{}], external Id [{}]",
+                    loan.getId(), loan.getAccountNumber(), externalId);
+
+            // Change the Action Context to DEFAULT for Business Date so that we can compare the loan due date
+            // to the current date and not the previous (COB) date.
+            ThreadLocalContextUtil.setActionContext(ActionContext.DEFAULT);
+            if (loan.getLoanProductRelatedDetails() != null && loan.getLoanProductRelatedDetails().getDelinquencyBucket() != null) {
+                log.trace("Evaluate {} Working Capital Delinquency bucket", loan.getLoanProductRelatedDetails().getDelinquencyBucket());

Review Comment:
   Any reason to use TRACE logging instead of DEBUG?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060216877


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/cob/workingcapitalloan/businessstep/WorkingCapitalLoanDelinquencyClassificationBusinessStep.java:
##########
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.cob.workingcapitalloan.businessstep;
+
+import static org.apache.fineract.infrastructure.core.diagnostics.performance.MeasuringUtil.measure;
+
+import java.util.Optional;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.infrastructure.core.domain.ActionContext;
+import org.apache.fineract.infrastructure.core.domain.ExternalId;
+import org.apache.fineract.infrastructure.core.service.ThreadLocalContextUtil;
+import org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoan;
+import org.apache.fineract.portfolio.workingcapitalloan.service.WorkingCapitalLoanDelinquencyClassificationService;
+import org.springframework.stereotype.Component;
+
+@Slf4j
+@RequiredArgsConstructor
+@Component
+public class WorkingCapitalLoanDelinquencyClassificationBusinessStep extends WorkingCapitalLoanCOBBusinessStep {
+
+    private final WorkingCapitalLoanDelinquencyClassificationService delinquencyClassificationService;
+
+    @Override
+    public WorkingCapitalLoan execute(WorkingCapitalLoan loan) {
+        if (loan == null) {
+            log.debug("Ignoring Working Capital delinquency tag processing for null loan.");
+            return null;
+        }
+        String externalId = Optional.ofNullable(loan.getExternalId()).map(ExternalId::getValue).orElse(null);
+        measure(() -> setDelinquencyBucketTags(loan, externalId), duration -> {
+            log.debug(
+                    "Ending Working Capital delinquency tag processing for loan with Id [{}], account number [{}], external Id [{}], finished in [{}]ms",
+                    loan.getId(), loan.getAccountNumber(), externalId, duration.toMillis());
+        });
+        return loan;
+    }
+
+    public void setDelinquencyBucketTags(WorkingCapitalLoan loan, String externalId) {
+        try {
+            log.debug(
+                    "Starting Working Capital delinquency tag processing for Working Capital Loan with Id [{}], account number [{}], external Id [{}]",
+                    loan.getId(), loan.getAccountNumber(), externalId);
+
+            // Change the Action Context to DEFAULT for Business Date so that we can compare the loan due date
+            // to the current date and not the previous (COB) date.
+            ThreadLocalContextUtil.setActionContext(ActionContext.DEFAULT);

Review Comment:
   Since this is a new business step, no pre-existing logic, we can stick to COB date and make the evaluations aware. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060198909


##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/WorkingCapitalLoanAccountStepDef.java:
##########
@@ -646,6 +646,9 @@ public void checkDisbursementData(String actualDisbursementDate, String transact
                 .orElseThrow(() -> new RuntimeException(""));
         String formattedDate = disbursementDetails.getActualDisbursementDate().format(FORMATTER);
         assertThat(formattedDate).isEqualTo(actualDisbursementDate);
+        log.info(

Review Comment:
   Probably we dont need this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4178428665

   @somasorosdpc Please rebase.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #5702:
URL: https://github.com/apache/fineract/pull/5702#issuecomment-4205682730

   @somasorosdpc Please rebase.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-2455: WC - Delinquency Management - Delinquency days & Delinquency Bucket handling [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5702:
URL: https://github.com/apache/fineract/pull/5702#discussion_r3060221509


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/data/WorkingCapitalLoanCollectionData.java:
##########
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.portfolio.workingcapitalloan.data;
+
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.util.ArrayList;
+import java.util.Collection;
+import lombok.AllArgsConstructor;
+import lombok.Data;
+import org.apache.fineract.portfolio.loanaccount.data.DelinquencyPausePeriod;
+
+@Data
+@AllArgsConstructor
+public class WorkingCapitalLoanCollectionData {
+
+    private Long delinquentDays;
+    private LocalDate delinquentDate;
+    private BigDecimal delinquentAmount;
+
+    public Collection<DelinquencyPausePeriod> delinquencyPausePeriods;

Review Comment:
   Use `List` please.



##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/data/WorkingCapitalLoanCollectionData.java:
##########
@@ -0,0 +1,49 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.fineract.portfolio.workingcapitalloan.data;
+
+import java.math.BigDecimal;
+import java.time.LocalDate;
+import java.util.ArrayList;
+import java.util.Collection;
+import lombok.AllArgsConstructor;
+import lombok.Data;
+import org.apache.fineract.portfolio.loanaccount.data.DelinquencyPausePeriod;
+
+@Data
+@AllArgsConstructor
+public class WorkingCapitalLoanCollectionData {
+
+    private Long delinquentDays;
+    private LocalDate delinquentDate;
+    private BigDecimal delinquentAmount;
+
+    public Collection<DelinquencyPausePeriod> delinquencyPausePeriods;
+    public Collection<WorkingCapitalLoanRangeScheduleDelinquencyData> rangeLevelDelinquency;

Review Comment:
   Use `List` please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org