You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/07/13 07:56:55 UTC

[GitHub] zeppelin pull request #1178: [Zeppelin-1167] Group $scope.$on functions

GitHub user corneadoug opened a pull request:

    https://github.com/apache/zeppelin/pull/1178

    [Zeppelin-1167] Group $scope.$on functions

    ### What is this PR for?
    This is a small refactoring PR for zeppelin-web.
    This is moving all the code's `$scope.$on` functions together at the end of each controller file.
    
    
    ### What type of PR is it?
    Refactoring
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1167
    
    ### How should this be tested?
    No test is needed, the code was just moved around
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1167

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1178
    
----
commit fd35dbd4cf48a8b32e50c15d2b9f0c5e143f9ce9
Author: Damien CORNEAU <co...@gmail.com>
Date:   2016-07-13T07:51:25Z

    group .on functions at the end of the controllers

commit d82300437025856e592fea28316061e5c136f5e0
Author: Damien CORNEAU <co...@gmail.com>
Date:   2016-07-13T07:52:01Z

    Fix indentation in result-list controller

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1178: [Zeppelin-1167] Group $scope.$on functions

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1178


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1178: [Zeppelin-1167] Group $scope.$on functions

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1178
  
    Rebased and CI is green.
    Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---