You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/02 17:14:00 UTC

[jira] [Work logged] (HIVE-25935) Cleanup IMetaStoreClient#getPartitionsByNames APIs

     [ https://issues.apache.org/jira/browse/HIVE-25935?focusedWorklogId=735418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-735418 ]

ASF GitHub Bot logged work on HIVE-25935:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Mar/22 17:13
            Start Date: 02/Mar/22 17:13
    Worklog Time Spent: 10m 
      Work Description: pvary opened a new pull request #3072:
URL: https://github.com/apache/hive/pull/3072


   ### What changes were proposed in this pull request?
   Cleans up deprecated methods
   
   ### Why are the changes needed?
   We do not want to release deprecated methods
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Unit tests will show errors, if any


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 735418)
    Remaining Estimate: 0h
            Time Spent: 10m

> Cleanup IMetaStoreClient#getPartitionsByNames APIs
> --------------------------------------------------
>
>                 Key: HIVE-25935
>                 URL: https://issues.apache.org/jira/browse/HIVE-25935
>             Project: Hive
>          Issue Type: Task
>          Components: Metastore
>            Reporter: Stamatis Zampetakis
>            Assignee: Peter Vary
>            Priority: Major
>             Fix For: 4.0.0-alpha-1
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the [IMetastoreClient|https://github.com/apache/hive/blob/4b7a948e45fd88372fef573be321cda40d189cc7/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java] interface has 8 variants of the {{getPartitionsByNames}} method. Going quickly over the concrete implementation it appears that not all of them are useful/necessary so a bit of cleanup is needed.
> Below a few potential problems I observed:
> * Some of the APIs are not used anywhere in the project (neither by production nor by test code).
> * Some of the APIs are deprecated in some concrete implementations but not globally at the interface level without an explanation why.
> * Some of the implementations simply throw without doing anything.
> * Many of the APIs are partially tested or not tested at all.
> HIVE-24743, HIVE-25281 are related since they introduce/deprecate some of the aforementioned APIs.
> It would be good to review the aforementioned APIs and decide what needs to stay and what needs to go as well as complete necessary when relevant.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)