You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/12/29 23:34:13 UTC

Review Request 29466: Fix non-deterministic unit test in Flume sink

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29466/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Mahadev Konar, and Myroslav Papirkovskyy.


Bugs: AMBARI-8946
    https://issues.apache.org/jira/browse/AMBARI-8946


Repository: ambari


Description
-------

Unit test fails from time to time

Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.783 sec <<< FAILURE!
testMetricsRetrievalExceptionTolerance(org.apache.hadoop.metrics2.sink.flume.FlumeTimelineMetricsSinkTest)  Time elapsed: 0.024 sec  <<< FAILURE!
java.lang.AssertionError:
  Expectation failure on verify:
    JMXPollUtil.getAllMBeans(): expected: 1, actual: 1
	at org.easymock.internal.MocksControl.verify(MocksControl.java:226)
	at org.powermock.api.easymock.internal.invocationcontrol.EasyMockMethodInvocationControl.verify(EasyMockMethodInvocationControl.java:120)
	at org.powermock.api.easymock.PowerMock.verifyClass(PowerMock.java:2272)
	at org.powermock.api.easymock.PowerMock.verify(PowerMock.java:1646)
	at org.powermock.api.easymock.PowerMock.verifyAll(PowerMock.java:1586)
	at org.apache.hadoop.metrics2.sink.flume.FlumeTimelineMetricsSinkTest.testMetricsRetrievalExceptionTolerance(FlumeTimelineMetricsSinkTest.java:115)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)


Diffs
-----

  ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 87c4ab8 
  ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java ad59576 
  ambari-server/src/main/resources/common-services/AMS/0.1.0/metainfo.xml 3c87fd7 

Diff: https://reviews.apache.org/r/29466/diff/


Testing
-------

Results :

Tests run: 89, Failures: 0, Errors: 0, Skipped: 4


Thanks,

Sid Wagle

Re: Review Request 29466: Fix non-deterministic unit test in Flume sink

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29466/#review66312
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On Dec. 29, 2014, 10:34 p.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29466/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2014, 10:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Mahadev Konar, and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-8946
>     https://issues.apache.org/jira/browse/AMBARI-8946
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Unit test fails from time to time
> 
> Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.783 sec <<< FAILURE!
> testMetricsRetrievalExceptionTolerance(org.apache.hadoop.metrics2.sink.flume.FlumeTimelineMetricsSinkTest)  Time elapsed: 0.024 sec  <<< FAILURE!
> java.lang.AssertionError:
>   Expectation failure on verify:
>     JMXPollUtil.getAllMBeans(): expected: 1, actual: 1
> 	at org.easymock.internal.MocksControl.verify(MocksControl.java:226)
> 	at org.powermock.api.easymock.internal.invocationcontrol.EasyMockMethodInvocationControl.verify(EasyMockMethodInvocationControl.java:120)
> 	at org.powermock.api.easymock.PowerMock.verifyClass(PowerMock.java:2272)
> 	at org.powermock.api.easymock.PowerMock.verify(PowerMock.java:1646)
> 	at org.powermock.api.easymock.PowerMock.verifyAll(PowerMock.java:1586)
> 	at org.apache.hadoop.metrics2.sink.flume.FlumeTimelineMetricsSinkTest.testMetricsRetrievalExceptionTolerance(FlumeTimelineMetricsSinkTest.java:115)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java 87c4ab8 
>   ambari-metrics/ambari-metrics-flume-sink/src/test/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSinkTest.java ad59576 
>   ambari-server/src/main/resources/common-services/AMS/0.1.0/metainfo.xml 3c87fd7 
> 
> Diff: https://reviews.apache.org/r/29466/diff/
> 
> 
> Testing
> -------
> 
> Results :
> 
> Tests run: 89, Failures: 0, Errors: 0, Skipped: 4
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>