[GitHub] [superset] kgabryje commented on a diff in pull request #20743: feat: Pass dashboard context to explore through local storage

[GitBox <gi...@apache.org>]

kgabryje commented on code in PR #20743:
URL: https://github.com/apache/superset/pull/20743#discussion_r924808703


##########
superset-frontend/src/dashboard/actions/hydrate.js:
##########
@@ -256,6 +258,19 @@ export const hydrateDashboard =
         layout[layoutId].meta.sliceName = slice.slice_name;
       }
     });
+
+    // make sure that parents tree is built
+    if (
+      Object.values(layout).some(
+        element => element.id !== DASHBOARD_ROOT_ID && !element.parents,
+      )
+    ) {
+      updateComponentParentsList({

Review Comment:
   Some sample dashboards don't have `parents` in their layout metadata, which caused e2e tests to fail



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org