You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zy-kkk (via GitHub)" <gi...@apache.org> on 2024/09/18 10:02:37 UTC
[PR] [improvement](jdbc catalog) Improve JdbcClientException to accommodate various identifier formats [doris]
zy-kkk opened a new pull request, #40931:
URL: https://github.com/apache/doris/pull/40931
In some cases, JDBC returns exceptions with various identifiers that cannot be formatted correctly, such as `%`. This PR optimizes this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](jdbc catalog) Improve JdbcClientException to accommodate various identifier formats [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40931:
URL: https://github.com/apache/doris/pull/40931#issuecomment-2358117934
<details>
<summary>TPC-H: <b>Total hot run time: 41853 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d32a1881d8a47b9f51ed1a9127e6a0d1a11565fd, data reload: false
------ Round 1 ----------------------------------
q1 17647 7380 7343 7343
q2 2041 158 168 158
q3 11757 1076 1167 1076
q4 10545 737 801 737
q5 7748 3069 3104 3069
q6 239 149 149 149
q7 1014 613 593 593
q8 10075 2043 2061 2043
q9 6800 6449 6469 6449
q10 7024 2257 2343 2257
q11 436 247 242 242
q12 405 220 223 220
q13 18265 3144 3129 3129
q14 258 221 233 221
q15 591 568 534 534
q16 934 636 625 625
q17 1146 800 838 800
q18 8796 7112 6799 6799
q19 1489 1042 1104 1042
q20 573 293 290 290
q21 4018 3220 3093 3093
q22 1125 984 1025 984
Total cold run time: 112926 ms
Total hot run time: 41853 ms
----- Round 2, with runtime_filter_mode=off -----
q1 7197 7196 7324 7196
q2 325 233 236 233
q3 3081 2941 2972 2941
q4 2080 1774 1774 1774
q5 5600 5566 5749 5566
q6 234 144 141 141
q7 2183 1805 1838 1805
q8 3279 3411 3416 3411
q9 8838 8893 8832 8832
q10 3477 3518 3464 3464
q11 575 478 477 477
q12 835 629 640 629
q13 15533 3141 3223 3141
q14 321 284 277 277
q15 569 531 529 529
q16 721 668 676 668
q17 1968 1595 1577 1577
q18 8141 7792 7856 7792
q19 1704 1668 1645 1645
q20 2138 1881 1871 1871
q21 5443 5326 5314 5314
q22 1128 1072 1020 1020
Total cold run time: 75370 ms
Total hot run time: 60303 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](jdbc catalog) Improve JdbcClientException to accommodate various identifier formats [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40931:
URL: https://github.com/apache/doris/pull/40931#issuecomment-2358141424
<details>
<summary>TPC-DS: <b>Total hot run time: 199040 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d32a1881d8a47b9f51ed1a9127e6a0d1a11565fd, data reload: false
query1 1273 882 911 882
query2 6389 2075 2094 2075
query3 10757 4011 4006 4006
query4 63648 29008 23406 23406
query5 5012 498 471 471
query6 409 176 166 166
query7 5446 307 296 296
query8 313 220 234 220
query9 8114 2683 2651 2651
query10 437 292 268 268
query11 17396 15186 15799 15186
query12 153 104 102 102
query13 1476 424 427 424
query14 10425 7230 7828 7230
query15 220 187 180 180
query16 7008 473 481 473
query17 1237 603 618 603
query18 1615 303 297 297
query19 199 145 149 145
query20 135 110 109 109
query21 206 110 103 103
query22 4831 4423 4794 4423
query23 34620 34130 33980 33980
query24 6062 2984 2929 2929
query25 505 373 404 373
query26 628 159 156 156
query27 1641 283 288 283
query28 4122 2453 2432 2432
query29 652 406 405 405
query30 229 151 144 144
query31 933 780 783 780
query32 67 55 50 50
query33 436 302 288 288
query34 887 490 479 479
query35 830 716 752 716
query36 1066 954 914 914
query37 153 87 88 87
query38 4073 3941 3919 3919
query39 1461 1398 1410 1398
query40 205 95 92 92
query41 46 45 45 45
query42 120 98 101 98
query43 543 483 491 483
query44 1158 816 793 793
query45 189 165 162 162
query46 1130 793 783 783
query47 1932 1787 1817 1787
query48 470 361 367 361
query49 672 383 389 383
query50 840 414 413 413
query51 6995 6880 6825 6825
query52 99 87 87 87
query53 257 177 178 177
query54 567 453 450 450
query55 78 76 81 76
query56 282 264 264 264
query57 1194 1106 1070 1070
query58 220 226 223 223
query59 3306 2981 2947 2947
query60 293 265 264 264
query61 128 96 98 96
query62 747 647 638 638
query63 222 187 194 187
query64 1347 655 646 646
query65 3277 3188 3234 3188
query66 671 304 301 301
query67 15967 15710 15453 15453
query68 1218 562 567 562
query69 413 285 296 285
query70 1166 1135 1185 1135
query71 333 270 276 270
query72 4885 4011 3958 3958
query73 780 327 336 327
query74 9352 8937 8978 8937
query75 3303 2672 2700 2672
query76 1332 842 918 842
query77 445 305 300 300
query78 9950 9520 9403 9403
query79 1301 913 905 905
query80 864 588 575 575
query81 523 251 265 251
query82 1273 236 229 229
query83 227 162 159 159
query84 289 102 98 98
query85 742 404 372 372
query86 324 322 304 304
query87 4321 4332 4309 4309
query88 4304 4116 4098 4098
query89 401 368 367 367
query90 1688 316 311 311
query91 166 168 158 158
query92 78 74 75 74
query93 973 907 915 907
query94 672 384 343 343
query95 461 427 433 427
query96 498 497 495 495
query97 3186 3194 3115 3115
query98 248 236 237 236
query99 1481 1275 1293 1275
Total cold run time: 305216 ms
Total hot run time: 199040 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](jdbc catalog) Improve JdbcClientException to accommodate various identifier formats [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40931:
URL: https://github.com/apache/doris/pull/40931#issuecomment-2358151375
<details>
<summary>ClickBench: <b>Total hot run time: 32.25 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d32a1881d8a47b9f51ed1a9127e6a0d1a11565fd, data reload: false
query1 0.05 0.04 0.04
query2 0.06 0.03 0.03
query3 0.23 0.06 0.07
query4 1.67 0.10 0.10
query5 0.51 0.49 0.52
query6 1.13 0.76 0.73
query7 0.02 0.01 0.01
query8 0.04 0.03 0.03
query9 0.56 0.51 0.50
query10 0.54 0.56 0.56
query11 0.14 0.10 0.10
query12 0.14 0.11 0.11
query13 0.60 0.60 0.58
query14 3.02 2.93 2.99
query15 0.88 0.83 0.81
query16 0.38 0.39 0.37
query17 1.06 1.06 1.06
query18 0.19 0.18 0.19
query19 1.96 1.82 1.97
query20 0.01 0.02 0.01
query21 15.37 0.57 0.57
query22 2.93 1.90 1.66
query23 17.30 0.98 0.81
query24 3.36 0.66 1.59
query25 0.25 0.18 0.06
query26 0.44 0.15 0.13
query27 0.03 0.03 0.04
query28 10.06 1.11 1.07
query29 12.57 3.29 3.23
query30 0.25 0.06 0.06
query31 2.88 0.37 0.38
query32 3.27 0.46 0.47
query33 3.00 3.01 3.02
query34 16.92 4.40 4.42
query35 4.43 4.43 4.43
query36 0.66 0.48 0.51
query37 0.08 0.06 0.06
query38 0.05 0.04 0.03
query39 0.04 0.02 0.02
query40 0.15 0.12 0.12
query41 0.08 0.02 0.03
query42 0.03 0.02 0.02
query43 0.03 0.03 0.03
Total cold run time: 107.37 s
Total hot run time: 32.25 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](jdbc catalog) Improve JdbcClientException to accommodate various identifier formats [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40931:
URL: https://github.com/apache/doris/pull/40931#issuecomment-2358036046
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [improvement](jdbc catalog) Improve JdbcClientException to accommodate various identifier formats [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk commented on PR #40931:
URL: https://github.com/apache/doris/pull/40931#issuecomment-2358036129
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org