You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/30 09:19:03 UTC

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #6786: [BYOC] FTVMAnnotateTarget method signature update

lhutton1 commented on a change in pull request #6786:
URL: https://github.com/apache/incubator-tvm/pull/6786#discussion_r514963025



##########
File path: python/tvm/relay/op/contrib/arm_compute_lib.py
##########
@@ -248,8 +242,11 @@ def conv2d(attrs, args):
     return True
 
 
-def qnn_conv2d(attrs, args):
+# TODO check why no annotation is here

Review comment:
       Just an fyi, the reason qnn.conv2d wasn't registered is because as an individual operator it isn't supported. It needs to be accompanied with a requantize op.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org