You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "spangaer (via GitHub)" <gi...@apache.org> on 2023/02/10 14:09:41 UTC
[GitHub] [incubator-pekko-persistence-dynamodb] spangaer opened a new pull request, #12: Add setSelect(ALL_ATTRIBUTES) to retrieve snapshots
spangaer opened a new pull request, #12:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/12
By doing so, the indexes don't need to have ProjectionStrategy ALL, but KEYS_ONLY suffices. Thus, a duplicate of the payload doesn't need to be stored in the index, which is more space efficient.
This allows to make the choice between time and space efficiency, by selecting the projection strategy for the created index. Depending on the choice, setting this flag for retrieval will make either strategy work as efficient as intended.
**Draft note**
I'm well aware that the rename refactor and deployment processes are still ongoing. We'll adapt these commits to the new reality as it materializes but wanted to stage the contributions already.
Also FYI @coreyoconnor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] coreyoconnor commented on pull request #12: Add setSelect(ALL_ATTRIBUTES) to retrieve snapshots
Posted by "coreyoconnor (via GitHub)" <gi...@apache.org>.
coreyoconnor commented on PR #12:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/12#issuecomment-1442695820
Looks like a nice change!
Two thoughts:
1. That comment on the tradeoff depending on how the index is configured should be copied here: https://github.com/apache/incubator-pekko-persistence-dynamodb/blob/27f9e016b2cc610e66e28b75bb7305d1e5ef4cee/src/main/scala/akka/persistence/dynamodb/query/scaladsl/DynamoDBCurrentPersistenceIdsQuery.scala#L64
1. I think this kind of change will need a minor version bump. Depending on how the secondary index is configured, an existing user may see a difference in behavior/performance with the version that includes this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add setSelect(ALL_ATTRIBUTES) to retrieve snapshots [incubator-pekko-persistence-dynamodb]
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #12:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/12#issuecomment-1863252966
I guess the build failures are unrelated to the feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-dynamodb] spangaer commented on pull request #12: Add setSelect(ALL_ATTRIBUTES) to retrieve snapshots
Posted by "spangaer (via GitHub)" <gi...@apache.org>.
spangaer commented on PR #12:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/12#issuecomment-1517577048
We'll address point 1 upon rebase.
Point 2, while I don't mind the version bump, I don't think there will be a performance impact.
It didn't work without projecting all before. If you project all, it will keep on working in the same way it did before (inside Dynamo). Only if you don't project all with will behave differently on on the Dynamo side, but that way of working didn't work before this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add setSelect(ALL_ATTRIBUTES) to retrieve snapshots [incubator-pekko-persistence-dynamodb]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #12:
URL: https://github.com/apache/incubator-pekko-persistence-dynamodb/pull/12#issuecomment-1863272773
something weird getting cached on GitHub CI cache storage - I've cleared all the caches and will see what happens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org