You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/02/23 01:25:30 UTC
[jira] Created: (HIVE-1189) Add package-info.java to Hive
Add package-info.java to Hive
-----------------------------
Key: HIVE-1189
URL: https://issues.apache.org/jira/browse/HIVE-1189
Project: Hadoop Hive
Issue Type: New Feature
Affects Versions: 0.6.0
Reporter: Zheng Shao
Fix For: 0.6.0
Hadoop automatically generates build/src/org/apache/hadoop/package-info.java with information like this:
{code}
/*
* Generated by src/saveVersion.sh
*/
@HadoopVersionAnnotation(version="0.20.2-dev", revision="826568",
user="zshao", date="Sun Oct 18 17:46:56 PDT 2009", url="http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20")
package org.apache.hadoop;
{code}
Hive should do the same thing so that we can easily know the version of the code at runtime.
This will help us identify whether we are still running the same version of Hive, if we serialize the plan and later continue the execution (See HIVE-1100).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-1189) Add package-info.java to Hive
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao reassigned HIVE-1189:
--------------------------------
Assignee: Zheng Shao
> Add package-info.java to Hive
> -----------------------------
>
> Key: HIVE-1189
> URL: https://issues.apache.org/jira/browse/HIVE-1189
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1189.1.patch
>
>
> Hadoop automatically generates build/src/org/apache/hadoop/package-info.java with information like this:
> {code}
> /*
> * Generated by src/saveVersion.sh
> */
> @HadoopVersionAnnotation(version="0.20.2-dev", revision="826568",
> user="zshao", date="Sun Oct 18 17:46:56 PDT 2009", url="http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20")
> package org.apache.hadoop;
> {code}
> Hive should do the same thing so that we can easily know the version of the code at runtime.
> This will help us identify whether we are still running the same version of Hive, if we serialize the plan and later continue the execution (See HIVE-1100).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1189) Add package-info.java to Hive
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837483#action_12837483 ]
John Sichi commented on HIVE-1189:
----------------------------------
Can you think of a way to add an automated negative test?
Regarding the check itself, you are comparing the version, but not the revision. Don't we need to check both?
> Add package-info.java to Hive
> -----------------------------
>
> Key: HIVE-1189
> URL: https://issues.apache.org/jira/browse/HIVE-1189
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1189.1.patch
>
>
> Hadoop automatically generates build/src/org/apache/hadoop/package-info.java with information like this:
> {code}
> /*
> * Generated by src/saveVersion.sh
> */
> @HadoopVersionAnnotation(version="0.20.2-dev", revision="826568",
> user="zshao", date="Sun Oct 18 17:46:56 PDT 2009", url="http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20")
> package org.apache.hadoop;
> {code}
> Hive should do the same thing so that we can easily know the version of the code at runtime.
> This will help us identify whether we are still running the same version of Hive, if we serialize the plan and later continue the execution (See HIVE-1100).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1189) Add package-info.java to Hive
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1189:
-----------------------------
Attachment: HIVE-1189.1.patch
The logic is copied from Hadoop.
> Add package-info.java to Hive
> -----------------------------
>
> Key: HIVE-1189
> URL: https://issues.apache.org/jira/browse/HIVE-1189
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1189.1.patch
>
>
> Hadoop automatically generates build/src/org/apache/hadoop/package-info.java with information like this:
> {code}
> /*
> * Generated by src/saveVersion.sh
> */
> @HadoopVersionAnnotation(version="0.20.2-dev", revision="826568",
> user="zshao", date="Sun Oct 18 17:46:56 PDT 2009", url="http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20")
> package org.apache.hadoop;
> {code}
> Hive should do the same thing so that we can easily know the version of the code at runtime.
> This will help us identify whether we are still running the same version of Hive, if we serialize the plan and later continue the execution (See HIVE-1100).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1189) Add package-info.java to Hive
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1189:
-----------------------------
Status: Open (was: Patch Available)
The patch has some conflicts with latest trunk--can you regenerate?
> Add package-info.java to Hive
> -----------------------------
>
> Key: HIVE-1189
> URL: https://issues.apache.org/jira/browse/HIVE-1189
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1189.1.patch
>
>
> Hadoop automatically generates build/src/org/apache/hadoop/package-info.java with information like this:
> {code}
> /*
> * Generated by src/saveVersion.sh
> */
> @HadoopVersionAnnotation(version="0.20.2-dev", revision="826568",
> user="zshao", date="Sun Oct 18 17:46:56 PDT 2009", url="http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20")
> package org.apache.hadoop;
> {code}
> Hive should do the same thing so that we can easily know the version of the code at runtime.
> This will help us identify whether we are still running the same version of Hive, if we serialize the plan and later continue the execution (See HIVE-1100).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HIVE-1189) Add package-info.java to Hive
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838148#action_12838148 ]
Zheng Shao commented on HIVE-1189:
----------------------------------
I am checking the BuildVersion which contains everything.
I need to think of a way to do a negative test.
> Add package-info.java to Hive
> -----------------------------
>
> Key: HIVE-1189
> URL: https://issues.apache.org/jira/browse/HIVE-1189
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1189.1.patch
>
>
> Hadoop automatically generates build/src/org/apache/hadoop/package-info.java with information like this:
> {code}
> /*
> * Generated by src/saveVersion.sh
> */
> @HadoopVersionAnnotation(version="0.20.2-dev", revision="826568",
> user="zshao", date="Sun Oct 18 17:46:56 PDT 2009", url="http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20")
> package org.apache.hadoop;
> {code}
> Hive should do the same thing so that we can easily know the version of the code at runtime.
> This will help us identify whether we are still running the same version of Hive, if we serialize the plan and later continue the execution (See HIVE-1100).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1189) Add package-info.java to Hive
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1189:
-----------------------------
Status: Patch Available (was: Open)
> Add package-info.java to Hive
> -----------------------------
>
> Key: HIVE-1189
> URL: https://issues.apache.org/jira/browse/HIVE-1189
> Project: Hadoop Hive
> Issue Type: New Feature
> Affects Versions: 0.6.0
> Reporter: Zheng Shao
> Assignee: Zheng Shao
> Fix For: 0.6.0
>
> Attachments: HIVE-1189.1.patch
>
>
> Hadoop automatically generates build/src/org/apache/hadoop/package-info.java with information like this:
> {code}
> /*
> * Generated by src/saveVersion.sh
> */
> @HadoopVersionAnnotation(version="0.20.2-dev", revision="826568",
> user="zshao", date="Sun Oct 18 17:46:56 PDT 2009", url="http://svn.apache.org/repos/asf/hadoop/common/branches/branch-0.20")
> package org.apache.hadoop;
> {code}
> Hive should do the same thing so that we can easily know the version of the code at runtime.
> This will help us identify whether we are still running the same version of Hive, if we serialize the plan and later continue the execution (See HIVE-1100).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.