[GitHub] [maven-plugin-tools] pzygielo commented on a change in pull request #51: [MPLUGIN-380] - Always include threadSafety in report

[GitBox <gi...@apache.org>]

pzygielo commented on a change in pull request #51:
URL: https://github.com/apache/maven-plugin-tools/pull/51#discussion_r753723637



##########
File path: maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginXdocGenerator.java
##########
@@ -312,17 +312,15 @@ private void writeGoalAttributes( MojoDescriptor mojoDescriptor, XMLWriter w )
                 w.writeMarkup( format( "pluginxdoc.mojodescriptor.dependencyCollectionRequired", value ) );
                 w.endElement(); //li
             }
-
-            if ( extendedMojoDescriptor.isThreadSafe() )
-            {
-                addedUl = addUl( w, addedUl );
-                w.startElement( "li" );
-                w.writeMarkup( getString( "pluginxdoc.mojodescriptor.threadSafe" ) );
-                w.endElement(); //li
-            }
-
         }
 
+        addedUl = addUl( w, addedUl );
+        w.startElement( "li" );
+        w.writeMarkup( getString( mojoDescriptor.isThreadSafe()

Review comment:
       - Please check #50 first.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org