You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by Hendrik Dev <he...@gmail.com> on 2014/06/28 23:25:40 UTC
fix suggestion for JsonStreamParser.isIntegralNumber()
isIntegralNumber() also have to throw a IllegalStateException
isIntegralNumber() does now throw ise, little renaming, cleanup of
possibly unnecessary code
https://github.com/salyh/fleece_tmp/commit/0a06c65d7934354cb1ed9873a47159030049df68
Thanks
Hendrik
Re: fix suggestion for JsonStreamParser.isIntegralNumber()
Posted by Romain Manni-Bucau <rm...@gmail.com>.
yes, no issue with github. Actually I think we can even ask for a
proxy on github (copy of the repo with some interesting hooks avoiding
jira + patch).
BTW you are right escaped is not correctly used. The idea was to know
if next char was to escaped or not.
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-06-29 0:28 GMT+02:00 Hendrik Dev <he...@gmail.com>:
> "boolean escaped" is never read, so i commented it out to open a
> discussion about the purpose of this variable. Syntactically the
> variable seems to be unnecessary.
>
> Sorry for mixing things up, will do a separate commit in the future
> for every discussion point or fix.
> (In the above commit i also renamed a method and fixed a trivial typo)
>
> Is it (in general) ok to post github commit proposals and discuss
> these before i create jira tickets/patches?
>
> Thanks
> Hendrik
>
>
>
> On Sun, Jun 29, 2014 at 12:00 AM, Romain Manni-Bucau
> <rm...@gmail.com> wrote:
>> Same as the other thread, do you care creating a patch and attaching to a jira?
>>
>> BTW you removed boolean escaped = false;, I guess cause of your other
>> patch. Would be great to not mix them ;)
>>
>>
>> Romain Manni-Bucau
>> Twitter: @rmannibucau
>> Blog: http://rmannibucau.wordpress.com/
>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>> Github: https://github.com/rmannibucau
>>
>>
>> 2014-06-28 23:25 GMT+02:00 Hendrik Dev <he...@gmail.com>:
>>> isIntegralNumber() also have to throw a IllegalStateException
>>>
>>> isIntegralNumber() does now throw ise, little renaming, cleanup of
>>> possibly unnecessary code
>>> https://github.com/salyh/fleece_tmp/commit/0a06c65d7934354cb1ed9873a47159030049df68
>>>
>>> Thanks
>>> Hendrik
Re: fix suggestion for JsonStreamParser.isIntegralNumber()
Posted by Hendrik Dev <he...@gmail.com>.
"boolean escaped" is never read, so i commented it out to open a
discussion about the purpose of this variable. Syntactically the
variable seems to be unnecessary.
Sorry for mixing things up, will do a separate commit in the future
for every discussion point or fix.
(In the above commit i also renamed a method and fixed a trivial typo)
Is it (in general) ok to post github commit proposals and discuss
these before i create jira tickets/patches?
Thanks
Hendrik
On Sun, Jun 29, 2014 at 12:00 AM, Romain Manni-Bucau
<rm...@gmail.com> wrote:
> Same as the other thread, do you care creating a patch and attaching to a jira?
>
> BTW you removed boolean escaped = false;, I guess cause of your other
> patch. Would be great to not mix them ;)
>
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
> 2014-06-28 23:25 GMT+02:00 Hendrik Dev <he...@gmail.com>:
>> isIntegralNumber() also have to throw a IllegalStateException
>>
>> isIntegralNumber() does now throw ise, little renaming, cleanup of
>> possibly unnecessary code
>> https://github.com/salyh/fleece_tmp/commit/0a06c65d7934354cb1ed9873a47159030049df68
>>
>> Thanks
>> Hendrik
Re: fix suggestion for JsonStreamParser.isIntegralNumber()
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Same as the other thread, do you care creating a patch and attaching to a jira?
BTW you removed boolean escaped = false;, I guess cause of your other
patch. Would be great to not mix them ;)
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-06-28 23:25 GMT+02:00 Hendrik Dev <he...@gmail.com>:
> isIntegralNumber() also have to throw a IllegalStateException
>
> isIntegralNumber() does now throw ise, little renaming, cleanup of
> possibly unnecessary code
> https://github.com/salyh/fleece_tmp/commit/0a06c65d7934354cb1ed9873a47159030049df68
>
> Thanks
> Hendrik