You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/11/03 19:52:42 UTC

[GitHub] [guacamole-server] mike-jumper commented on a change in pull request #307: GUACAMOLE-1205: Update Guacamole Server version numbers for 1.3.0 release

mike-jumper commented on a change in pull request #307:
URL: https://github.com/apache/guacamole-server/pull/307#discussion_r516918016



##########
File path: src/libguac/Makefile.am
##########
@@ -135,7 +135,7 @@ libguac_la_CFLAGS = \
     -Werror -Wall -pedantic
 
 libguac_la_LDFLAGS =     \
-    -version-info 18:0:1 \
+    -version-info 19:0:2 \

Review comment:
       I believe `age` needs to be reset to 0 as interfaces were changed (a new `protocol_version` member was added to the non-opaque `guac_user_info` structure). Code expecting the newer version of `guac_user_info` may not work (segfault) if it is given an older version and it attempts to access `protocol_version`.
   
   If `guac_user_info` were opaque (with its members exposed only through getter functions), this would be correct.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org