You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "TheRealFalcon (via GitHub)" <gi...@apache.org> on 2023/07/10 17:51:41 UTC
[GitHub] [cloudstack-documentation] TheRealFalcon opened a new pull request, #331: Update some cloud-init documentation
TheRealFalcon opened a new pull request, #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331
- Remove ds-identify.cfg configuration as that's no longer needed
- Change 'set-password' references to 'set_password' as the name has changed.
- Add a warning about disabled hostkey generation as this can result in a MITM
- Small typos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] TheRealFalcon commented on a diff in pull request #331: Update some cloud-init documentation
Posted by "TheRealFalcon (via GitHub)" <gi...@apache.org>.
TheRealFalcon commented on code in PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331#discussion_r1273577578
##########
source/adminguide/templates/_cloud_init.rst:
##########
@@ -75,15 +65,15 @@ These features can be implemented in `“Linux template creation process” <_cr
#. **Password management**
- Cloudstack integration with cloud-init `set-passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
+ Cloudstack integration with cloud-init `set_passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
- - **Enable set-passwords module on every boot**
+ - **Enable set_passwords module on every boot**
- By default the set-passwords module runs only on first boot of the instance, change that to run on every boot.
+ By default the set_passwords module runs only on first boot of the instance, change that to run on every boot.
.. code:: bash
- sudo sed -i s/" - set-passwords"/" - [set-passwords, always]"/g /etc/cloud/cloud.cfg
Review Comment:
Good point. Both `-` and `_` are and always have been valid in module names. We're moving all modules to use `_` going forward (starting in 23.3), and may enforce it in the future. I pushed an update to detect either `set-password` or `set_password` and write it as `set_password`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] rohityadavcloud merged pull request #331: Update some cloud-init documentation
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] weizhouapache commented on a diff in pull request #331: Update some cloud-init documentation
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331#discussion_r1271665376
##########
source/adminguide/templates/_cloud_init.rst:
##########
@@ -75,15 +65,15 @@ These features can be implemented in `“Linux template creation process” <_cr
#. **Password management**
- Cloudstack integration with cloud-init `set-passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
+ Cloudstack integration with cloud-init `set_passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
- - **Enable set-passwords module on every boot**
+ - **Enable set_passwords module on every boot**
- By default the set-passwords module runs only on first boot of the instance, change that to run on every boot.
+ By default the set_passwords module runs only on first boot of the instance, change that to run on every boot.
.. code:: bash
- sudo sed -i s/" - set-passwords"/" - [set-passwords, always]"/g /etc/cloud/cloud.cfg
Review Comment:
@TheRealFalcon
in my template (the cloud-init version is 23.1.2), it still uses `set-passwords`
would be good to mention the cloud-init version of old/new setting ?
##########
source/adminguide/templates/_cloud_init.rst:
##########
@@ -75,15 +65,15 @@ These features can be implemented in `“Linux template creation process” <_cr
#. **Password management**
- Cloudstack integration with cloud-init `set-passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
+ Cloudstack integration with cloud-init `set_passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
Review Comment:
@TheRealFalcon
are you saying that cloud-init can get the new password from cloudstack VR (password server) ?
if it works, it would be awesome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] TheRealFalcon commented on a diff in pull request #331: Update some cloud-init documentation
Posted by "TheRealFalcon (via GitHub)" <gi...@apache.org>.
TheRealFalcon commented on code in PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331#discussion_r1273578937
##########
source/adminguide/templates/_cloud_init.rst:
##########
@@ -75,15 +65,15 @@ These features can be implemented in `“Linux template creation process” <_cr
#. **Password management**
- Cloudstack integration with cloud-init `set-passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
+ Cloudstack integration with cloud-init `set_passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
Review Comment:
I become aware it from this documentation!
But based on the code (I haven't tested it personally), it appears that's what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] weizhouapache commented on a diff in pull request #331: Update some cloud-init documentation
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331#discussion_r1274268969
##########
source/adminguide/templates/_cloud_init.rst:
##########
@@ -75,15 +65,15 @@ These features can be implemented in `“Linux template creation process” <_cr
#. **Password management**
- Cloudstack integration with cloud-init `set-passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
+ Cloudstack integration with cloud-init `set_passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
Review Comment:
good to know it. thanks
##########
source/adminguide/templates/_cloud_init.rst:
##########
@@ -75,15 +65,15 @@ These features can be implemented in `“Linux template creation process” <_cr
#. **Password management**
- Cloudstack integration with cloud-init `set-passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
+ Cloudstack integration with cloud-init `set_passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
- - **Enable set-passwords module on every boot**
+ - **Enable set_passwords module on every boot**
- By default the set-passwords module runs only on first boot of the instance, change that to run on every boot.
+ By default the set_passwords module runs only on first boot of the instance, change that to run on every boot.
.. code:: bash
- sudo sed -i s/" - set-passwords"/" - [set-passwords, always]"/g /etc/cloud/cloud.cfg
Review Comment:
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] weizhouapache commented on pull request #331: Update some cloud-init documentation
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331#issuecomment-1650852124
@blueorangutan docbuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #331: Update some cloud-init documentation
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331#issuecomment-1650852452
@weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-documentation] TheRealFalcon commented on a diff in pull request #331: Update some cloud-init documentation
Posted by "TheRealFalcon (via GitHub)" <gi...@apache.org>.
TheRealFalcon commented on code in PR #331:
URL: https://github.com/apache/cloudstack-documentation/pull/331#discussion_r1273577578
##########
source/adminguide/templates/_cloud_init.rst:
##########
@@ -75,15 +65,15 @@ These features can be implemented in `“Linux template creation process” <_cr
#. **Password management**
- Cloudstack integration with cloud-init `set-passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
+ Cloudstack integration with cloud-init `set_passwords module <https://cloudinit.readthedocs.io/en/latest/topics/modules.html?highlight=ssh_pwauth#set-passwords>`_ will enable the platform to set a password for each instance created from the Main Template. Additionally it will allow to reset the user password through the GUI.
- - **Enable set-passwords module on every boot**
+ - **Enable set_passwords module on every boot**
- By default the set-passwords module runs only on first boot of the instance, change that to run on every boot.
+ By default the set_passwords module runs only on first boot of the instance, change that to run on every boot.
.. code:: bash
- sudo sed -i s/" - set-passwords"/" - [set-passwords, always]"/g /etc/cloud/cloud.cfg
Review Comment:
Good point. Both `-` and `_` are and always have been valid in module names. We're moving all modules to use `_` going forward, and may enforce it in the future. I pushed an update to detect either `set-password` or `set_password` and write it as `set_password`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org