You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/04/16 10:14:23 UTC
[GitHub] [cloudstack] onitake opened a new pull request #4035: Document how
to pass CIDRs lists API calls
onitake opened a new pull request #4035: Document how to pass CIDRs lists API calls
URL: https://github.com/apache/cloudstack/pull/4035
## Description
<!--- Describe your changes in detail -->
This patch adds a sentence to all CIDR_LIST and DEST_CIDR_LIST API parameter and return value annotations that documents how to pass a list of CIDRs.
This is a rarely used feature, but may be necessary for certain scenarios, such as automatic firewall rule generation/matching, VPNs with multiple routed networks, etc.
There may be other cases where the APIs accept lists, but this was out of scope for this PR.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
I tested what values the API calls createFirewallRule and createLoadBalancerRule accept for the cidrlist parameter, and what is returned in listFirewallRules and listLoadBalancerRules.
Anything besides a single comma is not accepted.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] onitake edited a comment on issue #4035: Document how
to pass CIDRs lists API calls
Posted by GitBox <gi...@apache.org>.
onitake edited a comment on issue #4035: Document how to pass CIDRs lists API calls
URL: https://github.com/apache/cloudstack/pull/4035#issuecomment-614594442
The integration test reports:
> The job exceeded the maximum log length, and has been terminated.
Does that mean the result can be ignored, or is there something I need to look into?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #4035: Document how to
pass CIDRs lists API calls
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4035: Document how to pass CIDRs lists API calls
URL: https://github.com/apache/cloudstack/pull/4035#issuecomment-615125386
> The integration test reports:
>
> > The job exceeded the maximum log length, and has been terminated.
>
> Does that mean the result can be ignored, or is there something I need to look into?
You can go to travis and restart the particular run, it may pass next time, (due to more cpu?) as it logs less async queries for instance, or logs less host pings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #4035: Document how to pass
CIDRs lists API calls
Posted by GitBox <gi...@apache.org>.
onitake commented on issue #4035: Document how to pass CIDRs lists API calls
URL: https://github.com/apache/cloudstack/pull/4035#issuecomment-615316145
Hm... It doesn't look like I can rerun builds on Travis.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #4035: Document how to pass
CIDRs lists API calls
Posted by GitBox <gi...@apache.org>.
onitake commented on issue #4035: Document how to pass CIDRs lists API calls
URL: https://github.com/apache/cloudstack/pull/4035#issuecomment-615220080
I can do that, once I figure out where to put this constant.
Hopefully it won't break the API doc parsing scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] onitake commented on issue #4035: Document how to pass
CIDRs lists API calls
Posted by GitBox <gi...@apache.org>.
onitake commented on issue #4035: Document how to pass CIDRs lists API calls
URL: https://github.com/apache/cloudstack/pull/4035#issuecomment-614594442
The integration test reports:
> The job exceeded the maximum log length, and has been terminated.
Does that mean the result can be ignored, or is there something I need to look into?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #4035: Document how to
pass CIDRs lists API calls
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #4035: Document how to pass CIDRs lists API calls
URL: https://github.com/apache/cloudstack/pull/4035#issuecomment-615269546
@onitake good point, i had not thought of that (yet)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services