[GitHub] brooklyn-server issue #791: Sync file system on temp file before moving it.

[geomacy <gi...@git.apache.org>]

Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/791
  
    @aledsage finally got round to checking this against the integration tests.
    
    It doesn't seem to have caused any significant problems - with a run of the tests against current `master` I got 7 failures:
    ```
    grep "^<testng-results" {core,camp/camp-brooklyn,launcher}/target/surefire-reports/testng-results.xml
    core/target/surefire-reports/testng-results.xml:<testng-results skipped="0" failed="3" ignored="2230" total="4492" passed="2259">
    camp/camp-brooklyn/target/surefire-reports/testng-results.xml:<testng-results skipped="0" failed="3" ignored="755" total="806" passed="48">
    launcher/target/surefire-reports/testng-results.xml:<testng-results skipped="0" failed="1" ignored="81" total="101" passed="19">
    ```
    
    With this PR I actually got fewer:
    ```
    grep "^<testng-results" {*,*/*}/target/surefire-reports/testng-results.xml | fgrep -v 'failed="0"'
    test-framework/target/surefire-reports/testng-results.xml:<testng-results skipped="0" failed="1" ignored="96" total="119" passed="22">
    camp/camp-brooklyn/target/surefire-reports/testng-results.xml:<testng-results skipped="0" failed="3" ignored="753" total="804" passed="48">
    ```
    
    Think this should be benign enough to merge.
    
    



---