Re: [PR] refactor: refactor compaction process for remote compaction [incubator-horaedb]

["jiacai2050 (via GitHub)" <gi...@apache.org>]

jiacai2050 commented on code in PR #1476:
URL: https://github.com/apache/incubator-horaedb/pull/1476#discussion_r1477167347


##########
src/horaedb/src/setup.rs:
##########
@@ -259,19 +266,14 @@ async fn run_server_with_runtimes<T>(
 }
 
 // Build proxy for all table engines.
-async fn build_table_engine_proxy(engine_builder: EngineBuilder<'_>) -> Arc<TableEngineProxy> {
+async fn build_table_engine_proxy(analytic_engine: TableEngineRef) -> Arc<TableEngineProxy> {

Review Comment:
   Maybe we can just name this `analytic`?



##########
.gitignore:
##########
@@ -6,6 +6,7 @@ target
 integration_tests/dist_query/dist-query-testing
 integration_tests/dist_query/tsbs
 integration_tests/dist_query/output
+integration_tests/ceresmeta/

Review Comment:
   This file is not used any more, you can just delete this file.
   
   In newer version, meta will be generated in `target` dir.



##########
src/benchmarks/src/merge_sst_bench.rs:
##########
@@ -83,12 +83,12 @@ impl MergeSstBench {
             num_streams_to_prefetch: 0,
         };
 
-        let maybe_table_level_metrics = Arc::new(SstMaybeTableLevelMetrics::new("bench", ""));
+        let _maybe_table_level_metrics = Arc::new(SstMaybeTableLevelMetrics::new("bench", ""));

Review Comment:
   Delete this if not used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org