You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/01/18 02:10:58 UTC
[GitHub] [iceberg] kbendick opened a new pull request #2103: Fix NarrowingCompoundAssignment warnings
kbendick opened a new pull request #2103:
URL: https://github.com/apache/iceberg/pull/2103
This fixes all current instances of `NarrowingCompoundAssignment` warnings when running `./gradlew check --continue`.
This does not handle the possibility of overflow when adding the current elements size or number of elements to the existing `cv.childCount`, but the old code did not handle that either.
I chose to continue to use the addition of `cv.lengths[rowId]`, which could have typically been substituted for `value.size()` / `data.size()` / `value.numElements()`, in the off chance that the input `ColumnVector` computes the `size` / `numElements` lazily each time that the method is called.
This closes issue https://github.com/apache/iceberg/issues/1290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2103: [MISC] Fix NarrowingCompoundAssignment warnings
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2103:
URL: https://github.com/apache/iceberg/pull/2103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org