You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@jspwiki.apache.org by Motohiko Matsuda <ma...@acm.org> on 2018/03/29 13:01:43 UTC

jspwiki reveals Main page without login

Hi,

First of all, thank you, developers of JSPWIKI.
We are using JSPWIKI very nicely as an internal wiki for a long time.

But, we needed to apply a fix before using JSPWIKI.
It reveals the content of the "Main" page without login,
when we omit the arguments to a JSP page.
For example, just "https://xxx/xxx/Edit.jsp" shows the Main page
(omitting the following "?page=xxx").
I have checked in 2.10.3, but it is not fixed.

We are happy if it will contribute to JSPWIKI.

	Regards,
	Motohiko Matsuda

Files need a fix:

Comment.jsp
Delete.jsp
Diff.jsp
Edit.jsp
PageInfo.jsp
PageModified.jsp
Preview.jsp
Rename.jsp

The diff (all files need the same fix):

--- Edit.jsp.org	Tue Feb 16 22:11:28 2016
+++ Edit.jsp	Tue Oct 17 11:47:04 2017
@@ -54,6 +54,8 @@
     // Create wiki context and check for authorization
     WikiContext wikiContext = wiki.createContext( request, WikiContext.EDIT );
     if(!wiki.getAuthorizationManager().hasAccess( wikiContext, response )) return;
+    if (wikiContext.getCommand().getTarget() == null) {return;}
     String pagereq = wikiContext.getName();

     WikiSession wikiSession = wikiContext.getWikiSession();

Re: jspwiki reveals Main page without login

Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
thanks for spotting it, Motohiko :-)

I've pushed 2.10.4-03 with a fix for this; instead of just returning
there's also a sendRedirect so the request can be routed to the Login.jsp
page, with the appropiate redirect parameter (I was getting a blank page
with the return alone). I'm also deploying a snapshot right now, so it
should be available in ~45 minutes.


best regards,
juan pablo

On Thu, Mar 29, 2018 at 3:01 PM, Motohiko Matsuda <ma...@acm.org> wrote:

> Hi,
>
> First of all, thank you, developers of JSPWIKI.
> We are using JSPWIKI very nicely as an internal wiki for a long time.
>
> But, we needed to apply a fix before using JSPWIKI.
> It reveals the content of the "Main" page without login,
> when we omit the arguments to a JSP page.
> For example, just "https://xxx/xxx/Edit.jsp" shows the Main page
> (omitting the following "?page=xxx").
> I have checked in 2.10.3, but it is not fixed.
>
> We are happy if it will contribute to JSPWIKI.
>
>         Regards,
>         Motohiko Matsuda
>
> Files need a fix:
>
> Comment.jsp
> Delete.jsp
> Diff.jsp
> Edit.jsp
> PageInfo.jsp
> PageModified.jsp
> Preview.jsp
> Rename.jsp
>
> The diff (all files need the same fix):
>
> --- Edit.jsp.org        Tue Feb 16 22:11:28 2016
> +++ Edit.jsp    Tue Oct 17 11:47:04 2017
> @@ -54,6 +54,8 @@
>      // Create wiki context and check for authorization
>      WikiContext wikiContext = wiki.createContext( request,
> WikiContext.EDIT );
>      if(!wiki.getAuthorizationManager().hasAccess( wikiContext, response
> )) return;
> +    if (wikiContext.getCommand().getTarget() == null) {return;}
>      String pagereq = wikiContext.getName();
>
>      WikiSession wikiSession = wikiContext.getWikiSession();
>

removing a cache entry of a referer page

Posted by Motohiko Matsuda <ma...@acm.org>.
Dear jspwiki developers,

It seems that a referer link is left un-updated (shown in red) after a
target page is created.  It is not a big trouble, because
WYSWYG-previewing the referer page clears the cache.

But, just browsing the code in "RenderingManager.java", it is likely
that the page IDs are not identical in m_documentCache.get() and
m_documentCache.put().  I am sorry if I am wrong.

We are using jspwiki very nicely.  This is my second post.  I very
appreciated the quick fix in the previous issue.  Thanks, anyway.

	Motohiko Matsuda