You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/02/11 17:42:45 UTC

[GitHub] couchdb-fauxton pull request: Style fix for selecting text in Ace ...

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/266

    Style fix for selecting text in Ace editor

    This PR contains two things:
    1. reverts an old custom change to the Ace editor theme file
    2. updates the select text style, as per: https://issues.apache.org/jira/browse/COUCHDB-2573

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2560-ace-editor-theme-update

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/266.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #266
    
----
commit 1287abf9da29b965338a6559f7769e71ec3b3666
Author: Ben Keen <be...@gmail.com>
Date:   2015-02-11T16:31:47Z

    Revert "Style fix for clicking on doc line nums"
    
    This reverts commit b53a4db5a4d48320da28fd0f9dd173cb94c67f5b.

commit 3f51e122a8730e615bed23b69ebb94d8ceb10557
Author: Ben Keen <be...@gmail.com>
Date:   2015-02-11T16:40:24Z

    Style fix for selected text in Ace editor
    
    This updates the background color and the location of the selected
    text bg color.
    
    Closes COUCHDB-2573

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Style fix for selecting text in Ace ...

Posted by robertkowalski <gi...@git.apache.org>.

Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/266#issuecomment-74057497
  
    +1 
    
    merge it! :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Style fix for selecting text in Ace ...

Posted by benkeen <gi...@git.apache.org>.

Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/266#issuecomment-74091892
  
    Thanks @robertkowalski! @seanbarclay, could I get you to glance at this today?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Style fix for selecting text in Ace ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/266


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---