[GitHub] [solr-operator] HoustonPutman commented on pull request #359: Add ability to schedule recurring incremental backups

[GitBox <gi...@apache.org>]

HoustonPutman commented on pull request #359:
URL: https://github.com/apache/solr-operator/pull/359#issuecomment-957772393


   1. I'm content with a `purgeEvery` option in Solr. I'm not sure I understand why you would want un-garbage collected index files laying about, but that's definitely a different issue. We can definitely go ahead and purge after every backup until the `purgeEvery` option is added. (Oh now I realize you mean a `purgeEvery` option in the CRD. I think we can assume that would be equivalent to `saveEvery`.)
   I did talk with @anshumg about a ticket that saw some issues with purging that does make me a bit wary to do it always. https://issues.apache.org/jira/browse/SOLR-15706
   We should make sure that's not an issue before going forward with that.
   2. That's a good idea. I do think I want to have it "enabled" by default. Which is easy to do with those kubebuilder annotations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org