[GitHub] [nifi] adarmiento commented on a change in pull request #3738: NIFI-6672 Expression language plus operation doesn't check for overflow

[GitBox <gi...@apache.org>]

adarmiento commented on a change in pull request #3738: NIFI-6672 Expression language plus operation doesn't check for overflow 
URL: https://github.com/apache/nifi/pull/3738#discussion_r324463741
 
 

 ##########
 File path: nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java
 ##########
 @@ -993,8 +993,21 @@ public void testMathWholeNumberOperations() {
         attributes.put("four", "4");
         attributes.put("five", "5");
         attributes.put("hundred", "100");
+        attributes.put("max_long", String.valueOf(Long.MAX_VALUE));
 
         verifyEquals("${hundred:toNumber():multiply(${two}):divide(${three}):plus(${one}):mod(${five})}", attributes, 2L);
+
+
 
 Review comment:
   ```suggestion
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services