You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AliRana30 (via GitHub)" <gi...@apache.org> on 2026/02/07 09:43:27 UTC
[PR] GH-49153: [C++] Remove deprecated decimal() factory function [arrow]
AliRana30 opened a new pull request, #49171:
URL: https://github.com/apache/arrow/pull/49171
### Rationale for This Change
The `decimal()` factory function was deprecated in **Arrow v18.0.0** (over 6 years ago) in favor of `smallest_decimal()`. The deprecation grace period has long since passed, and the function is **no longer used anywhere in the C++ codebase**.
---
### What Changes Are Included in This PR?
This PR removes the deprecated factory function:
```cpp
decimal(int32_t precision, int32_t scale)
```
### Are These Changes Tested?
Yes.
- Verified via full codebase search that no usages remain.
- No new tests are required since this change removes unused, deprecated code.
### Are There Any User-Facing Changes?
Yes.
- The deprecated `decimal()` factory function is removed.
- Users should instead use:
- `smallest_decimal()`, or
- the explicit factory functions: `decimal32()`, `decimal64()`, or `decimal128()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2826792956
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
The **flight_sql:extension** scenario tests the **CancelQuery** action, which this PR removes from C++ (it was deprecated in v13.0.0, **August 2023**).
C++ now uses **[CancelFlightInfo]** instead, which is the replacement API. However, other languages (Java, Go) still implement the old CancelQuery action.
Without this skip, the integration tests fail with:
Action not implemented: CancelQuery rpc error: code = Unimplemented desc = Action not implemented: CancelQuery
Since C++ no longer supports the deprecated **CancelQuery** action being tested in this scenario, it needs to be skipped from cross-language testing for this specific scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3938643163
@kou This PR doesn't cover GH-49153 entirely.
I'll:
1. Create a new issue specifically for these 3 C++ API removals.
2. Create a separate issue for the CancelQuery cross-repo work.
This keeps the scope focused and allows GH-49153 to remain open for future deprecation work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49356: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3940780174
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 8c27898d36f45ece9b0d114b3d6c6a42d20bde7f.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/64439613354) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated decimal() factory function [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3864038375
:warning: GitHub issue #49153 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2826571449
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
Why do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2832953486
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
You're right - skipping C++ would skip all extension tests, not just **CancelQuery**.
Looking at the code, the C++ integration test already uses [CancelFlightInfo] (the replacement API). The failures were happening because the integration test servers in Java/Go still expect the CancelQuery action.
Would you prefer:
**1.**I remove CancelQuery from Java/Go integration test servers as well (they also deprecated it), OR
**2.**I keep the C++ skip for now, and we can remove CancelQuery from all languages in a coordinated PR?
Option 1 would make this PR more complete, but touches Java/Go code beyond just C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49356: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3939600631
:warning: GitHub issue #49356 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2830765196
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
Can we update the Java and Go implementations instead of skipping C++ tests? If we skip the C++ implementation, non `CancelQuery` tests are also skipped, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2832953486
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
You're right - skipping C++ would skip all extension tests, not just CancelQuery.
Looking at the code, the C++ integration test already uses [CancelFlightInfo] (the replacement API). The failures were happening because the integration test servers in Java/Go still expect the CancelQuery action.
Would you prefer:
**1.**I remove CancelQuery from Java/Go integration test servers as well (they also deprecated it), OR
**2.**I keep the C++ skip for now, and we can remove CancelQuery from all languages in a coordinated PR?
Option 1 would make this PR more complete, but touches Java/Go code beyond just C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3926836374
@rok I've now properly verified everything.
I've expanded the PR to remove all C++ APIs that were deprecated before January 2025:
1.**decimal() function** - deprecated in PR #43957, released in v18.0.0 (October 2024)
2.**FlightSql CancelQuery() (both server and client)** - deprecated in PR #36009, released in v13.0.0 (August 2023)
3.**cuda::DefaultMemoryMapper()** - deprecated in PR #40699, released in v16.0.0 (April 2024)
I also updated the integration tests that were using CancelQuery() to use the replacement CancelFlightInfo() API, and skipped C++ from the flight_sql:extension scenario since it now uses the newer API. I've verified there are no remaining usages of any of these deprecated symbols in the codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2826792956
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
The **flight_sql:extension** scenario tests the **CancelQuery** action, which this PR removes from C++ (it was deprecated in v13.0.0, **August 2023**).
C++ now uses **[CancelFlightInfo]** instead, which is the replacement API. However, other languages (Java, Go) still implement the old CancelQuery action.
Without this skip, the integration tests fail with:
"Action not implemented: CancelQuery rpc error: code = Unimplemented desc = Action not implemented: CancelQuery"
Since C++ no longer supports the deprecated **CancelQuery** action being tested in this scenario, it needs to be skipped from cross-language testing for this specific scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3937883664
BTW, does this cover GH-49153 entirely? If this focuses only some parts of GH-49153, we should open a new issue for this instead of using GH-49153. If we merge this PR that is associated with GH-49153, GH-49153 will be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2833507499
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
> 1.Wait for those to be merged
Are there already PRs in apache/arrow-java and apache/arrow-go to migrate to CancelFlightInfo from CancelQuery?
If you want to complete this PR as soon as possible, I prefer the following step:
1. Remove CancelQuery related change from this PR
2. Merge this PR
3. Open a PR to apache/arrow-java to migrate to CancelFlightInfo from CancelQuery
4. Merge the PR
5. Open a PR to apache/arrow-go to migrate to CancelFlightInfo from CancelQuery
6. Merge the PR
7. Open a separated PR to this repository to migrate to CancelFlightInfo from CancelQuery
8. Merge the PR
If you don't mind this PR keeps opening, I prefer the following step:
1. Open a PR to apache/arrow-java to migrate to CancelFlightInfo from CancelQuery
2. Merge the PR
3. Open a PR to apache/arrow-go to migrate to CancelFlightInfo from CancelQuery
4. Merge the PR
5. Remove the C++ skip from this PR
6. Merge this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2833228746
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
Option 1 is better.
We need to work on https://github.com/apache/arrow-java for Java and https://github.com/apache/arrow-go for Go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3923045830
@rok! I've now properly verified everything.
I've expanded the PR to remove all C++ APIs that were deprecated before January 2025:
1.**ServerAuthHandler::IsValid() (old signature)** - deprecated in PR #35378, released in v13.0.0 (August 2023)
2.**decimal() function** - deprecated in PR #43957, released in v18.0.0 (October 2024)
3.**FlightSql CancelQuery() (both server and client)** - deprecated in PR #36009, released in v13.0.0 (August 2023)
4.**cuda::DefaultMemoryMapper()** - deprecated in PR #40699, released in v16.0.0 (April 2024).
I also updated the integration tests that were using CancelQuery() to use the replacement CancelFlightInfo() API instead. I've verified there are no remaining usages of any of these deprecated symbols in the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3933884773
@kou You're absolutely right - skipping C++ would skip all extension tests, not just CancelQuery.
Looking at the code, the C++ integration test already uses [CancelFlightInfo] (the replacement API). The failures were happening because the integration test servers in Java/Go still expect the CancelQuery action.
Would you prefer:
**1.**I remove CancelQuery from Java/Go integration test servers as well (they also deprecated it), OR
**2.**I keep the C++ skip for now, and we can remove CancelQuery from all languages in a coordinated PR?
Option 1 would make this PR more complete, but touches Java/Go code beyond just C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated decimal() factory function [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3867508245
@rok You're absolutely right about the dates. I apologize - decimal() was deprecated in September 2024 (only 4 months ago), not "over 6 years ago" as I mistakenly claimed.
I'll close this PR and create a new one with properly verified deprecations >1 year old (before 2025) with PR links and release dates as you requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated decimal() factory function [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3864253300
This PR looks ok, however test looks AI generated so I checked the statement. It turns out `decimal` was not deprecated "over 6 years ago" but rather in November 2024 when 18.1.0 was released. PR for deprecation was merged on [4th September 2024](https://github.com/apache/arrow/pull/43957/changes#diff-79bec37f77fa174c78a55b17c75d71fe6b566b04e1fc82385f00b76ac908d63eR533).
Since I don't want to search for every claim you make here, please do the following:
* expand this PR to all C++ symbols you want to deprecate and rename it appropriately
* provide PR links where deprecation notice was given (per symbol) and the release where this commit was then released
e.g.:
* `decimal` was deprecated on [4th September 2024](https://github.com/apache/arrow/pull/43957/changes#diff-79bec37f77fa174c78a55b17c75d71fe6b566b04e1fc82385f00b76ac908d63eR533) which was a part of 18.1.0 (November 2024).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2834202253
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
Thanks for the guidance! I'll go with option of removing CancelQuery from this PR to get the other deprecations merged faster. Because this PR is purely for only those deprecations that are linked with C++ only.
I'll remove the CancelQuery changes and revert the integration test skip until this PR , so it gets merged and does'nt create mess of the tests and changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2833291129
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
Got it. Since Java and Go are in separate repos, should I:
1.Wait for those to be merged
2.Then update this PR to remove the C++ skip
Or would you prefer to keep the C++ skip in this PR for now, with a TODO comment that it can be removed once arrow-java and arrow-go are updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49356: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3939600646
:warning: GitHub issue #49356 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated decimal() factory function [arrow]
Posted by "rok (via GitHub)" <gi...@apache.org>.
rok commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3868108789
@AliRana30 you can rename the PR - there is an edit button at the top right of the page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated decimal() factory function [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 closed pull request #49171: GH-49153: [C++] Remove deprecated decimal() factory function
URL: https://github.com/apache/arrow/pull/49171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2833471938
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
We should create the PRs to remove CancelQuery on Arrow Java and Arrow Go and hold this PR until this is done. Skipping the whole flight sql integration tests could introduce integration issues without us noticing. You could also split the deprecation of CancelQuery to a follow up PR until the other PRs are merged (possibly add a TODO explaining why it can't be deprecated yet) and just push the other deprecation removals. Both approaches seem reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2833518234
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
(Wow. Raúl also said the same approaches. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "AliRana30 (via GitHub)" <gi...@apache.org>.
AliRana30 commented on code in PR #49171:
URL: https://github.com/apache/arrow/pull/49171#discussion_r2834202253
##########
dev/archery/archery/integration/runner.py:
##########
@@ -721,7 +721,7 @@ def run_all_tests(testers: List[Tester], other_testers: List[Tester],
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
- skip_testers={"Rust", ".NET"}
+ skip_testers={"Rust", ".NET", "C++"}
Review Comment:
Thanks for the guidance! I'll go with option of removing CancelQuery from this PR to get the other deprecations merged faster.
I'll remove the CancelQuery changes and revert the integration test skip until this PR , so it gets merged and does'nt create mess of the tests and changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49356: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #49171:
URL: https://github.com/apache/arrow/pull/49171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-49153: [C++] Remove deprecated APIs from v13.0.0 and v18.0.0 [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #49171:
URL: https://github.com/apache/arrow/pull/49171#issuecomment-3937881080
Could you open a new issue for the CancelQuery work?
Could you update the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org