You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jordan Ly <jo...@gmail.com> on 2017/05/11 17:13:28 UTC
Review Request 59163: Added 'aurora task scp' command for copying to
task instances
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
Bugs: AURORA-1925
https://issues.apache.org/jira/browse/AURORA-1925
Repository: aurora
Description
-------
Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
This command essentially mimics scp but expands task instances into their respective user@host:path
For scp, the root for a task instance is the sandbox folder.
Example usage:
From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
Diffs
-----
src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
Diff: https://reviews.apache.org/r/59163/diff/1/
Testing
-------
`./pants test src/test/python/apache/aurora/client/cli:cli`
```
20:17:35 00:02 [chroot]============== test session starts ===============
platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
plugins: timeout, cov
collected 175 items
src/test/python/apache/aurora/client/cli/test_config_noun.py ...
src/test/python/apache/aurora/client/cli/test_context.py ........
src/test/python/apache/aurora/client/cli/test_version.py .
src/test/python/apache/aurora/client/cli/test_quota.py .....
src/test/python/apache/aurora/client/cli/test_plugins.py .
src/test/python/apache/aurora/client/cli/test_client.py ..
src/test/python/apache/aurora/client/cli/test_sla.py .....
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
src/test/python/apache/aurora/client/cli/test_restart.py ..........
src/test/python/apache/aurora/client/cli/test_status.py .............
src/test/python/apache/aurora/client/cli/test_add.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ..
src/test/python/apache/aurora/client/cli/test_cron.py ..........
src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
src/test/python/apache/aurora/client/cli/test_options.py ......
src/test/python/apache/aurora/client/cli/test_task.py ...........
src/test/python/apache/aurora/client/cli/test_create.py ..............
src/test/python/apache/aurora/client/cli/test_kill.py ......................
src/test/python/apache/aurora/client/cli/test_inspect.py ....
src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
========== 175 passed in 26.42 seconds ===========
```
I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Jordan Ly <jo...@gmail.com>.
> On May 11, 2017, 5:46 p.m., Aurora ReviewBot wrote:
> > Master (b0d24f4) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorModule
> > Test coverage missing for org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1
> > Test coverage missing for org/apache/aurora/Protobufs
> > Test coverage missing for org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroUtils
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/ModuleParser
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroIniParser
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
> > Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
> > Test coverage missing for org/apache/aurora/scheduler/state/UUIDGenerator$UUIDGeneratorImpl
> > Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule
> > Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet
> > Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$OutputConfig
> > Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$ContentFactoryPair
> > Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$InputConfig
> > Test coverage missing for org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
> > Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$3
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$2
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$1
> > Test coverage missing for org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule
> > Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats
> > Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
> > Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
> > Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$TaskStatusReceived
> > Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
> > Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> > ==============================================================================
> >
> > BUILD FAILED
> >
> > Total time: 25 mins 14.098 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
@ReviewBox retry
- Jordan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174693
-----------------------------------------------------------
On May 14, 2017, 2:05 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 14, 2017, 2:05 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/2/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174693
-----------------------------------------------------------
Master (b0d24f4) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/configuration/executor/ExecutorModule
Test coverage missing for org/apache/aurora/scheduler/pruning/TaskHistoryPruner$1
Test coverage missing for org/apache/aurora/Protobufs
Test coverage missing for org/apache/aurora/scheduler/stats/AsyncStatsModule$OfferAdapter
Test coverage missing for org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroUtils
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ModuleParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$3
Test coverage missing for org/apache/aurora/scheduler/http/api/security/HttpSecurityModule$2
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroIniParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser
Test coverage missing for org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilter
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule
Test coverage missing for org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule$1
Test coverage missing for org/apache/aurora/scheduler/state/UUIDGenerator$UUIDGeneratorImpl
Test coverage missing for org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$OutputConfig
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$ContentFactoryPair
Test coverage missing for org/apache/aurora/scheduler/http/api/TContentAwareServlet$InputConfig
Test coverage missing for org/apache/aurora/scheduler/reconciliation/KillRetry$KillAttempt
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$3
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$2
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats$1
Test coverage missing for org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule
Test coverage missing for org/apache/aurora/scheduler/mesos/TaskStatusStats
Test coverage missing for org/apache/aurora/scheduler/preemptor/Preemptor$PreemptorImpl
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverDisconnected
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$TaskStatusReceived
Test coverage missing for org/apache/aurora/scheduler/events/PubsubEvent$DriverRegistered
Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/VolumeModeTypeHandler
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 25 mins 14.098 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174695
-----------------------------------------------------------
Awesome, LGTM overall. Just a minor note about the testing style.
src/test/python/apache/aurora/client/cli/test_task.py
Lines 214 (patched)
<https://reviews.apache.org/r/59163/#comment247901>
We have a bunch of this style of psuedo integration test where you have to do mock.patch to get anything to work... they are not fun to write or maintain.
We have tried to move away from this and towards actual unit tests where we instantiate the commands directly and call execute on them. See here: https://github.com/apache/aurora/blob/master/src/test/python/apache/aurora/client/cli/test_supdate.py#L517
- David McLaughlin
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174904
-----------------------------------------------------------
Master (b0d24f4) is red with this patch.
./build-support/jenkins/build.sh
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:commons:assemble
:commons:licenseMain
Unknown file extension: commons/src/main/resources/org/apache/aurora/common/net/http/handlers/thrift.st
:commons:licenseMain UP-TO-DATE
:commons:licenseTest
Unknown file extension: commons/src/test/resources/org/apache/aurora/common/util/templating/template.st
:commons:licenseTest UP-TO-DATE
:commons:license UP-TO-DATE
:commons:compileTestJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/classes/test/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /home/jenkins/jenkins-slave/workspace/AuroraBot/commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:commons:processTestResources
:commons:testClasses
:commons:test
org.apache.aurora.common.zookeeper.GroupTest > testJoinsAndWatchesSurviveExpiredSession FAILED
java.lang.AssertionError at GroupTest.java:193
185 tests completed, 1 failed
:commons:test FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':commons:test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/commons/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 5 mins 14.855 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 14, 2017, 2:05 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 14, 2017, 2:05 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/2/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175125
-----------------------------------------------------------
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Lines 481 (patched)
<https://reviews.apache.org/r/59163/#comment248491>
WRT todo, I think the convention is to create a ticket and mention it here.
- Reza Motamedi
On May 15, 2017, 10:26 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/3/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175181
-----------------------------------------------------------
Ship it!
Master (b00a15e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 15, 2017, 10:26 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/4/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175045
-----------------------------------------------------------
Ship it!
Master (b00a15e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 15, 2017, 10:26 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/3/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175124
-----------------------------------------------------------
Ship it!
Ship It!
- Reza Motamedi
On May 15, 2017, 10:26 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/3/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175357
-----------------------------------------------------------
Ship it!
Just a small nit.
src/test/python/apache/aurora/client/cli/test_task.py
Lines 322 (patched)
<https://reviews.apache.org/r/59163/#comment248805>
Use of magic strings from the unit under test here. Extract to constants and reuse them here (eg. ScpCommand.TILDE_USAGE_ERROR_MSG).
- David McLaughlin
On May 18, 2017, 6:12 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 6:12 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths and use
> '~' to access the role's home directory.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
> From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/6/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 23:07:10 00:03 [run]
> ============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: cov, timeout
> collected 179 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...............
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 179 passed in 24.88 seconds ===========
>
> 23:07:37 00:30 [complete]
> SUCCESS
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175434
-----------------------------------------------------------
Ship it!
Master (b00a15e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 18, 2017, 6:12 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 6:12 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Reza Motamedi.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths
> (ex. /tmp or /var/log). Tilde expansion is not supported (ex. paths like ~/some/dir will not work)
> as they will try to access home directories: in this case, the command will return an error.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
> From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/8/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 23:07:10 00:03 [run]
> ============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: cov, timeout
> collected 179 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...............
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 179 passed in 24.88 seconds ===========
>
> 23:07:37 00:30 [complete]
> SUCCESS
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175355
-----------------------------------------------------------
Ship it!
Master (b00a15e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 18, 2017, 6:12 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 6:12 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths and use
> '~' to access the role's home directory.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
> From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/6/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 23:07:10 00:03 [run]
> ============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: cov, timeout
> collected 179 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...............
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 179 passed in 24.88 seconds ===========
>
> 23:07:37 00:30 [complete]
> SUCCESS
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175405
-----------------------------------------------------------
Ship it!
Master (b00a15e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 18, 2017, 6:12 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 18, 2017, 6:12 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths and use
> '~' to access the role's home directory.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
> From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/7/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 23:07:10 00:03 [run]
> ============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: cov, timeout
> collected 179 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...............
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 179 passed in 24.88 seconds ===========
>
> 23:07:37 00:30 [complete]
> SUCCESS
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On May 18, 2017, 11:05 a.m., Santhosh Kumar Shanmugham wrote:
> > docs/reference/client-commands.md
> > Lines 310 (patched)
> > <https://reviews.apache.org/r/59163/diff/7/?file=1724101#file1724101line310>
> >
> > Please sync the commit message and the documentation, w.r.t the tilde usage.
Nevermind this comment. I see that it is updated in the latest diff.
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175404
-----------------------------------------------------------
On May 17, 2017, 11:12 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:12 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths
> (ex. /tmp or /var/log). Tilde expansion is not supported (ex. paths like ~/some/dir will not work)
> as they will try to access home directories: in this case, the command will return an error.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
> From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/7/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 23:07:10 00:03 [run]
> ============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: cov, timeout
> collected 179 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...............
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 179 passed in 24.88 seconds ===========
>
> 23:07:37 00:30 [complete]
> SUCCESS
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175404
-----------------------------------------------------------
Ship it!
Few minor comments.
docs/reference/client-commands.md
Lines 310 (patched)
<https://reviews.apache.org/r/59163/#comment248848>
Please sync the commit message and the documentation, w.r.t the tilde usage.
docs/reference/client-commands.md
Lines 312-313 (patched)
<https://reviews.apache.org/r/59163/#comment248847>
s/copy files from/read files from/
s/cannot copy file to/cannot write files to/
src/main/python/apache/aurora/client/cli/task.py
Lines 193 (patched)
<https://reviews.apache.org/r/59163/#comment248852>
nit - s/covert/convert/
src/main/python/apache/aurora/client/cli/task.py
Lines 209 (patched)
<https://reviews.apache.org/r/59163/#comment248853>
nit - s/expansions/expansion/
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Lines 361-362 (patched)
<https://reviews.apache.org/r/59163/#comment248859>
Assert non-existence before the test?
- Santhosh Kumar Shanmugham
On May 17, 2017, 11:12 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 11:12 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths
> (ex. /tmp or /var/log). Tilde expansion is not supported (ex. paths like ~/some/dir will not work)
> as they will try to access home directories: in this case, the command will return an error.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
> From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/7/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 23:07:10 00:03 [run]
> ============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: cov, timeout
> collected 179 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...............
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 179 passed in 24.88 seconds ===========
>
> 23:07:37 00:30 [complete]
> SUCCESS
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/
-----------------------------------------------------------
(Updated May 18, 2017, 6:12 a.m.)
Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
Changes
-------
Removed ability to do tilde expansion that was added in the previous review request.
Bugs: AURORA-1925
https://issues.apache.org/jira/browse/AURORA-1925
Repository: aurora
Description
-------
Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
This command essentially mimics scp but expands task instances into their respective user@host:path
For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths and use
'~' to access the role's home directory.
Example usage:
From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
Diffs (updated)
-----
RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
Diff: https://reviews.apache.org/r/59163/diff/6/
Changes: https://reviews.apache.org/r/59163/diff/5-6/
Testing (updated)
-------
`./pants test src/test/python/apache/aurora/client/cli:cli`
```
23:07:10 00:03 [run]
============== test session starts ===============
platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
plugins: cov, timeout
collected 179 items
src/test/python/apache/aurora/client/cli/test_config_noun.py ...
src/test/python/apache/aurora/client/cli/test_context.py ........
src/test/python/apache/aurora/client/cli/test_version.py .
src/test/python/apache/aurora/client/cli/test_quota.py .....
src/test/python/apache/aurora/client/cli/test_plugins.py .
src/test/python/apache/aurora/client/cli/test_client.py ..
src/test/python/apache/aurora/client/cli/test_sla.py .....
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
src/test/python/apache/aurora/client/cli/test_restart.py ..........
src/test/python/apache/aurora/client/cli/test_status.py .............
src/test/python/apache/aurora/client/cli/test_add.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ..
src/test/python/apache/aurora/client/cli/test_cron.py ..........
src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
src/test/python/apache/aurora/client/cli/test_options.py ......
src/test/python/apache/aurora/client/cli/test_task.py ...............
src/test/python/apache/aurora/client/cli/test_create.py ..............
src/test/python/apache/aurora/client/cli/test_kill.py ......................
src/test/python/apache/aurora/client/cli/test_inspect.py ....
src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
========== 179 passed in 24.88 seconds ===========
23:07:37 00:30 [complete]
SUCCESS
```
I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175325
-----------------------------------------------------------
Master (b00a15e) is red with this patch.
./build-support/jenkins/build.sh
Test coverage missing for org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule$2
Test coverage missing for org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule
Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout
Test coverage missing for org/apache/aurora/scheduler/reconciliation/TaskTimeout$TimedOutTaskHandler
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJob$CronBatchWorker
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/CronLifecycle
Test coverage missing for org/apache/aurora/scheduler/cron/quartz/AuroraCronJobFactory
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$TaskGroupBatchWorker
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups$1
Test coverage missing for org/apache/aurora/scheduler/scheduling/TaskGroups
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$2
Test coverage missing for org/apache/aurora/scheduler/storage/mem/MemTaskStore$SecondaryIndex$1
Test coverage missing for org/apache/aurora/scheduler/mesos/MesosTaskFactory$MesosTaskFactoryImpl
Test coverage missing for org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImpl
Test coverage missing for org/apache/aurora/scheduler/mesos/VersionedMesosSchedulerImpl$1
Test coverage missing for org/apache/aurora/scheduler/mesos/VersionedSchedulerDriverService
Test coverage missing for org/apache/aurora/scheduler/thrift/AuditMessages
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$1
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$2
Test coverage missing for org/apache/aurora/scheduler/preemptor/PendingTaskProcessor$3
Test coverage missing for org/apache/aurora/scheduler/preemptor/PreemptorModule$PreemptorService
Test coverage missing for org/apache/aurora/scheduler/events/WebhookModule
Test coverage missing for org/apache/aurora/scheduler/events/Webhook
Test coverage missing for org/apache/aurora/scheduler/events/WebhookInfo
Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl$1
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$Settings
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService
Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorageModule
Test coverage missing for org/apache/aurora/scheduler/storage/backup/BackupModule
Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions
Test coverage missing for org/apache/aurora/scheduler/TierManager$TierManagerImpl$TierConfig
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
BUILD FAILED
Total time: 6 mins 32.985 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 17, 2017, 10:41 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 10:41 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths and use
> '~' to access the role's home directory.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
> From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/5/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 15:36:04 00:07 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 179 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...............
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 179 passed in 36.80 seconds ===========
>
> 15:36:54 00:57 [complete]
> SUCCESS
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/
-----------------------------------------------------------
(Updated May 17, 2017, 10:41 p.m.)
Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
Changes
-------
Have the sandbox act as the relative root (no '/' or '~' or '~/' specified at beginning of path). Otherwise, use the absolute path or let the machine do the '~' expansion.
Bugs: AURORA-1925
https://issues.apache.org/jira/browse/AURORA-1925
Repository: aurora
Description (updated)
-------
Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
This command essentially mimics scp but expands task instances into their respective user@host:path
For 'aurora task scp' the sandbox is the relative root. However, you can still use absolute paths and use
'~' to access the role's home directory.
Example usage:
From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:`
From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:test.txt .`
From task tmp folder to host: `aurora task scp cluster/role/env/job/instance:/tmp/test.txt .`
From one task to another task: `aurora task scp cluster/role/env/job/instance:test.txt cluster/role/env/job/instance:some/dir/`
Diffs (updated)
-----
RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
Diff: https://reviews.apache.org/r/59163/diff/5/
Changes: https://reviews.apache.org/r/59163/diff/4-5/
Testing (updated)
-------
`./pants test src/test/python/apache/aurora/client/cli:cli`
```
15:36:04 00:07 [chroot]============== test session starts ===============
platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
plugins: timeout, cov
collected 179 items
src/test/python/apache/aurora/client/cli/test_config_noun.py ...
src/test/python/apache/aurora/client/cli/test_context.py ........
src/test/python/apache/aurora/client/cli/test_version.py .
src/test/python/apache/aurora/client/cli/test_quota.py .....
src/test/python/apache/aurora/client/cli/test_plugins.py .
src/test/python/apache/aurora/client/cli/test_client.py ..
src/test/python/apache/aurora/client/cli/test_sla.py .....
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
src/test/python/apache/aurora/client/cli/test_restart.py ..........
src/test/python/apache/aurora/client/cli/test_status.py .............
src/test/python/apache/aurora/client/cli/test_add.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ..
src/test/python/apache/aurora/client/cli/test_cron.py ..........
src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
src/test/python/apache/aurora/client/cli/test_options.py ......
src/test/python/apache/aurora/client/cli/test_task.py ...............
src/test/python/apache/aurora/client/cli/test_create.py ..............
src/test/python/apache/aurora/client/cli/test_kill.py ......................
src/test/python/apache/aurora/client/cli/test_inspect.py ....
src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
========== 179 passed in 36.80 seconds ===========
15:36:54 00:57 [complete]
SUCCESS
```
I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review175279
-----------------------------------------------------------
Forcing "/" to be the container sandbox essentially prevents copying files from (and perhaps to) other locations in the filesystem. Examples - copying a file to/from /tmp, copying a system log file from /var/log, or copying some random file which could help in debugging.
Suggestion - what about making the relative root to be the sandbox path so `aurora task scp ~/test.txt cluster/role/env/job/instance:`, would scp test.txt to $SANDBOX/test.txt while `aurora task scp cluster/role/env/job/instance:/tmp/test.txt` would copy from the task's /tmp directory? This seems a better match to both the standard experience with scp and with needs.
- Ian Downes
On May 15, 2017, 3:26 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 3:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/4/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/
-----------------------------------------------------------
(Updated May 15, 2017, 10:26 p.m.)
Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
Changes
-------
- Added documentation stating this command can only read/write with Mesos containers and read with Docker containers.
- Needed to add "patch" for "subprocess.call" in test_task.py or else executor tests would be effected.
Bugs: AURORA-1925
https://issues.apache.org/jira/browse/AURORA-1925
Repository: aurora
Description
-------
Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
This command essentially mimics scp but expands task instances into their respective user@host:path
For scp, the root for a task instance is the sandbox folder.
Example usage:
From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
Diffs (updated)
-----
RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
Diff: https://reviews.apache.org/r/59163/diff/3/
Changes: https://reviews.apache.org/r/59163/diff/2-3/
Testing
-------
`./pants test src/test/python/apache/aurora/client/cli:cli`
```
20:17:35 00:02 [chroot]============== test session starts ===============
platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
plugins: timeout, cov
collected 175 items
src/test/python/apache/aurora/client/cli/test_config_noun.py ...
src/test/python/apache/aurora/client/cli/test_context.py ........
src/test/python/apache/aurora/client/cli/test_version.py .
src/test/python/apache/aurora/client/cli/test_quota.py .....
src/test/python/apache/aurora/client/cli/test_plugins.py .
src/test/python/apache/aurora/client/cli/test_client.py ..
src/test/python/apache/aurora/client/cli/test_sla.py .....
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
src/test/python/apache/aurora/client/cli/test_restart.py ..........
src/test/python/apache/aurora/client/cli/test_status.py .............
src/test/python/apache/aurora/client/cli/test_add.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ..
src/test/python/apache/aurora/client/cli/test_cron.py ..........
src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
src/test/python/apache/aurora/client/cli/test_options.py ......
src/test/python/apache/aurora/client/cli/test_task.py ...........
src/test/python/apache/aurora/client/cli/test_create.py ..............
src/test/python/apache/aurora/client/cli/test_kill.py ......................
src/test/python/apache/aurora/client/cli/test_inspect.py ....
src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
========== 175 passed in 26.42 seconds ===========
```
I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/
-----------------------------------------------------------
(Updated May 14, 2017, 2:05 a.m.)
Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
Bugs: AURORA-1925
https://issues.apache.org/jira/browse/AURORA-1925
Repository: aurora
Description
-------
Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
This command essentially mimics scp but expands task instances into their respective user@host:path
For scp, the root for a task instance is the sandbox folder.
Example usage:
From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
Diffs (updated)
-----
RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
Diff: https://reviews.apache.org/r/59163/diff/2/
Changes: https://reviews.apache.org/r/59163/diff/1-2/
Testing
-------
`./pants test src/test/python/apache/aurora/client/cli:cli`
```
20:17:35 00:02 [chroot]============== test session starts ===============
platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
plugins: timeout, cov
collected 175 items
src/test/python/apache/aurora/client/cli/test_config_noun.py ...
src/test/python/apache/aurora/client/cli/test_context.py ........
src/test/python/apache/aurora/client/cli/test_version.py .
src/test/python/apache/aurora/client/cli/test_quota.py .....
src/test/python/apache/aurora/client/cli/test_plugins.py .
src/test/python/apache/aurora/client/cli/test_client.py ..
src/test/python/apache/aurora/client/cli/test_sla.py .....
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
src/test/python/apache/aurora/client/cli/test_restart.py ..........
src/test/python/apache/aurora/client/cli/test_status.py .............
src/test/python/apache/aurora/client/cli/test_add.py ....
src/test/python/apache/aurora/client/cli/test_diff.py ..
src/test/python/apache/aurora/client/cli/test_cron.py ..........
src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
src/test/python/apache/aurora/client/cli/test_options.py ......
src/test/python/apache/aurora/client/cli/test_task.py ...........
src/test/python/apache/aurora/client/cli/test_create.py ..............
src/test/python/apache/aurora/client/cli/test_kill.py ......................
src/test/python/apache/aurora/client/cli/test_inspect.py ....
src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
========== 175 passed in 26.42 seconds ===========
```
I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
Thanks,
Jordan Ly
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On May 11, 2017, 5:51 p.m., Aurora ReviewBot wrote:
> > Master (b0d24f4) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > virtualenv-15.0.2/virtualenv_support/__init__.py
> > virtualenv-15.0.2/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl
> > virtualenv-15.0.2/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl
> > virtualenv-15.0.2/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl
> > virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl
> > + touch virtualenv-15.0.2/BOOTSTRAPPED
> > + popd
> > /home/jenkins/jenkins-slave/workspace/AuroraBot
> > + exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py --no-download /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
> > New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
> > Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
> > Installing setuptools, pip, wheel...done.
> > Collecting isort==4.0.0
> > Downloading isort-4.0.0-py2.py3-none-any.whl
> > Installing collected packages: isort
> > Successfully installed isort-4.0.0
> > You are using pip version 8.1.2, however version 9.0.1 is available.
> > You should consider upgrading via the 'pip install --upgrade pip' command.
> > ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py Imports are incorrectly sorted.
> > --- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:before 2017-05-11 17:46:29.148758
> > +++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:after 2017-05-11 17:51:30.112057
> > @@ -31,16 +31,16 @@
> > from apache.aurora.client.cli.context import AuroraCommandContext
> > from apache.aurora.client.cli.options import (
> > ALL_INSTANCES,
> > - CommandOption,
> > EXECUTOR_SANDBOX_OPTION,
> > INSTANCES_SPEC_ARGUMENT,
> > + SCP_DEST_ARGUMENT,
> > SCP_OPTIONS,
> > SCP_SOURCE_ARGUMENT,
> > - SCP_DEST_ARGUMENT,
> > SSH_INSTANCE_ARGUMENT,
> > SSH_OPTIONS,
> > SSH_USER_OPTION,
> > TASK_INSTANCE_ARGUMENT,
> > + CommandOption,
> > parse_task_instance_key
> > )
> > from apache.aurora.common.clusters import CLUSTERS
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
I run into this all the time. If you want to predict what ReviewBot is doing, it's just giving the results of:
https://github.com/apache/aurora/blob/master/build-support/jenkins/build.sh
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174694
-----------------------------------------------------------
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174694
-----------------------------------------------------------
Master (b0d24f4) is red with this patch.
./build-support/jenkins/build.sh
virtualenv-15.0.2/virtualenv_support/__init__.py
virtualenv-15.0.2/virtualenv_support/argparse-1.4.0-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/pip-8.1.2-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/setuptools-21.2.1-py2.py3-none-any.whl
virtualenv-15.0.2/virtualenv_support/wheel-0.29.0-py2.py3-none-any.whl
+ touch virtualenv-15.0.2/BOOTSTRAPPED
+ popd
/home/jenkins/jenkins-slave/workspace/AuroraBot
+ exec /usr/bin/python2.7 /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-15.0.2/virtualenv.py --no-download /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv
New python executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python2.7
Also creating executable in /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/isort.venv/bin/python
Installing setuptools, pip, wheel...done.
Collecting isort==4.0.0
Downloading isort-4.0.0-py2.py3-none-any.whl
Installing collected packages: isort
Successfully installed isort-4.0.0
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
ERROR: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py Imports are incorrectly sorted.
--- /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:before 2017-05-11 17:46:29.148758
+++ /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/client/cli/task.py:after 2017-05-11 17:51:30.112057
@@ -31,16 +31,16 @@
from apache.aurora.client.cli.context import AuroraCommandContext
from apache.aurora.client.cli.options import (
ALL_INSTANCES,
- CommandOption,
EXECUTOR_SANDBOX_OPTION,
INSTANCES_SPEC_ARGUMENT,
+ SCP_DEST_ARGUMENT,
SCP_OPTIONS,
SCP_SOURCE_ARGUMENT,
- SCP_DEST_ARGUMENT,
SSH_INSTANCE_ARGUMENT,
SSH_OPTIONS,
SSH_USER_OPTION,
TASK_INSTANCE_ARGUMENT,
+ CommandOption,
parse_task_instance_key
)
from apache.aurora.common.clusters import CLUSTERS
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Jordan Ly <jo...@gmail.com>.
> On May 12, 2017, 1:55 p.m., Stephan Erb wrote:
> > Please also make you add a line to:
> >
> > * RELEASE-NOTES.md
> > * the client documentation https://github.com/apache/aurora/blob/master/docs/reference/client-commands.md#sshing-to-a-specific-task-machine
Added!
- Jordan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174789
-----------------------------------------------------------
On May 14, 2017, 2:05 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 14, 2017, 2:05 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4e930fb1c5b87bca3cf4d8de804d69301f013f07
> docs/reference/client-commands.md 582c96a642fd5855e482f62dc40971d6cc3659b5
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 1a81dc5dcde0400510c5576ac523f4d3f14424ca
>
>
> Diff: https://reviews.apache.org/r/59163/diff/2/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174789
-----------------------------------------------------------
Please also make you add a line to:
* RELEASE-NOTES.md
* the client documentation https://github.com/apache/aurora/blob/master/docs/reference/client-commands.md#sshing-to-a-specific-task-machine
- Stephan Erb
On May 11, 2017, 7:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 7:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On May 11, 2017, 11:12 a.m., Reza Motamedi wrote:
> > src/main/python/apache/aurora/client/cli/task.py
> > Lines 224-225 (patched)
> > <https://reviews.apache.org/r/59163/diff/1/?file=1715819#file1715819line224>
> >
> > Consider defending against some bash tricks, for instance what happens if the user set a path that has `~` or `../../../` to go up the dir chain.
>
> David McLaughlin wrote:
> I think it's fine to delegate that to the scp command, no? If they have the permissions to copy stuff outside of their container then you have bigger problems :)
>
> Santhosh Kumar Shanmugham wrote:
> Worth testing it on the vagrant box to see if you can break the chroot jail. I am pretty sure Mesos already handles this.
>
> David McLaughlin wrote:
> Or adding coverage to src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh.
+1
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174699
-----------------------------------------------------------
On May 11, 2017, 10:13 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 10:13 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On May 11, 2017, 6:12 p.m., Reza Motamedi wrote:
> > src/main/python/apache/aurora/client/cli/task.py
> > Lines 224-225 (patched)
> > <https://reviews.apache.org/r/59163/diff/1/?file=1715819#file1715819line224>
> >
> > Consider defending against some bash tricks, for instance what happens if the user set a path that has `~` or `../../../` to go up the dir chain.
I think it's fine to delegate that to the scp command, no? If they have the permissions to copy stuff outside of their container then you have bigger problems :)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174699
-----------------------------------------------------------
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On May 11, 2017, 6:12 p.m., Reza Motamedi wrote:
> > src/main/python/apache/aurora/client/cli/task.py
> > Lines 224-225 (patched)
> > <https://reviews.apache.org/r/59163/diff/1/?file=1715819#file1715819line224>
> >
> > Consider defending against some bash tricks, for instance what happens if the user set a path that has `~` or `../../../` to go up the dir chain.
>
> David McLaughlin wrote:
> I think it's fine to delegate that to the scp command, no? If they have the permissions to copy stuff outside of their container then you have bigger problems :)
>
> Santhosh Kumar Shanmugham wrote:
> Worth testing it on the vagrant box to see if you can break the chroot jail. I am pretty sure Mesos already handles this.
Or adding coverage to src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174699
-----------------------------------------------------------
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
> On May 11, 2017, 11:12 a.m., Reza Motamedi wrote:
> > src/main/python/apache/aurora/client/cli/task.py
> > Lines 224-225 (patched)
> > <https://reviews.apache.org/r/59163/diff/1/?file=1715819#file1715819line224>
> >
> > Consider defending against some bash tricks, for instance what happens if the user set a path that has `~` or `../../../` to go up the dir chain.
>
> David McLaughlin wrote:
> I think it's fine to delegate that to the scp command, no? If they have the permissions to copy stuff outside of their container then you have bigger problems :)
Worth testing it on the vagrant box to see if you can break the chroot jail. I am pretty sure Mesos already handles this.
- Santhosh Kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174699
-----------------------------------------------------------
On May 11, 2017, 10:13 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 10:13 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174699
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/task.py
Lines 167 (patched)
<https://reviews.apache.org/r/59163/#comment247911>
Help should be a bit longer here.
What does it accept?
aurora task scp zone/role/env/job/instance:from.txt to.txt
and
aurora task scp from.txt zone/role/env/job/instance:to.txt
?
src/main/python/apache/aurora/client/cli/task.py
Lines 170 (patched)
<https://reviews.apache.org/r/59163/#comment247905>
nitpicking... staticmethod?
src/main/python/apache/aurora/client/cli/task.py
Lines 179 (patched)
<https://reviews.apache.org/r/59163/#comment247907>
nitpicking... staticmethod?
I think when you are not really accessing instance data, you relly want a static method.
src/main/python/apache/aurora/client/cli/task.py
Lines 224-225 (patched)
<https://reviews.apache.org/r/59163/#comment247912>
Consider defending against some bash tricks, for instance what happens if the user set a path that has `~` or `../../../` to go up the dir chain.
- Reza Motamedi
On May 11, 2017, 5:13 p.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 5:13 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>
Re: Review Request 59163: Added 'aurora task scp' command for copying
to task instances
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59163/#review174691
-----------------------------------------------------------
LGTM. Some comments on UI.
src/main/python/apache/aurora/client/cli/options.py
Lines 275-279 (patched)
<https://reviews.apache.org/r/59163/#comment247899>
Can these be directories as well? Does it allow recursive copies too?
If they can be directories too, then the option names must read as `source` and `dest` perhaps?
Need a better help similar to scp like `[CLSUTER/ROLE/ENV/NAME/INSTANCE:]file`.
Is the `INSTANCE` filed optional - meaning we want to run this on all the instances?
src/main/python/apache/aurora/client/cli/task.py
Lines 196 (patched)
<https://reviews.apache.org/r/59163/#comment247913>
Should this be `instance not found`?
src/main/python/apache/aurora/client/cli/task.py
Lines 209-211 (patched)
<https://reviews.apache.org/r/59163/#comment247914>
Can we use `os.path` to build the path?
- Santhosh Kumar Shanmugham
On May 11, 2017, 10:13 a.m., Jordan Ly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59163/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 10:13 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Reza Motamedi, and Santhosh Kumar.
>
>
> Bugs: AURORA-1925
> https://issues.apache.org/jira/browse/AURORA-1925
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Added 'aurora task scp' command for copying/retrieving files to the sandbox of a task instance.
>
> This command essentially mimics scp but expands task instances into their respective user@host:path
> For scp, the root for a task instance is the sandbox folder.
>
> Example usage:
> From host to task sandbox folder: `aurora task scp ~/test.txt cluster/role/env/job/instance:/`
> From task sandbox folder to host: `aurora task scp cluster/role/env/job/instance:/test.txt .`
> From one task to another task: `aurora task scp cluster/role/env/job/instance:/test.txt cluster/role/env/job/instance:/some/dir/`
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/options.py 11687033ac93226732dd1a742fb6d80f86a557f2
> src/main/python/apache/aurora/client/cli/task.py 370dd7f730414641215dcd2da0b2a6037e6e1cf2
> src/test/python/apache/aurora/client/cli/test_task.py 390993fc55d7aa717f39e25375b2d6cfe96242d0
>
>
> Diff: https://reviews.apache.org/r/59163/diff/1/
>
>
> Testing
> -------
>
> `./pants test src/test/python/apache/aurora/client/cli:cli`
> ```
> 20:17:35 00:02 [chroot]============== test session starts ===============
> platform darwin -- Python 2.7.10 -- py-1.4.33 -- pytest-2.6.4
> plugins: timeout, cov
> collected 175 items
>
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
> src/test/python/apache/aurora/client/cli/test_context.py ........
> src/test/python/apache/aurora/client/cli/test_version.py .
> src/test/python/apache/aurora/client/cli/test_quota.py .....
> src/test/python/apache/aurora/client/cli/test_plugins.py .
> src/test/python/apache/aurora/client/cli/test_client.py ..
> src/test/python/apache/aurora/client/cli/test_sla.py .....
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_supdate.py .......................................
> src/test/python/apache/aurora/client/cli/test_restart.py ..........
> src/test/python/apache/aurora/client/cli/test_status.py .............
> src/test/python/apache/aurora/client/cli/test_add.py ....
> src/test/python/apache/aurora/client/cli/test_diff.py ..
> src/test/python/apache/aurora/client/cli/test_cron.py ..........
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
> src/test/python/apache/aurora/client/cli/test_options.py ......
> src/test/python/apache/aurora/client/cli/test_task.py ...........
> src/test/python/apache/aurora/client/cli/test_create.py ..............
> src/test/python/apache/aurora/client/cli/test_kill.py ......................
> src/test/python/apache/aurora/client/cli/test_inspect.py ....
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py ......
>
> ========== 175 passed in 26.42 seconds ===========
> ```
>
> I've also compiled it within the local cluster with Vagrant and used the command to transfer a text file between the scheduler machine and job I created.
>
>
> Thanks,
>
> Jordan Ly
>
>