You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/08/06 06:41:45 UTC

[GitHub] [couchdb] jiangphcn commented on a change in pull request #3057: fixup: Build couch_js for redhat linux

jiangphcn commented on a change in pull request #3057:
URL: https://github.com/apache/couchdb/pull/3057#discussion_r466178559



##########
File path: src/couch/rebar.config.script
##########
@@ -118,6 +118,11 @@ end,
             "-DXP_UNIX -I/usr/include/mozjs-60 -I/usr/local/include/mozjs-60 -std=c++14",
             "-L/usr/local/lib -lmozjs-60 -lm -std=c++14 -lc++"
         };
+    {unix, linux} when SMVsn == "60" ->

Review comment:
       @wohali thanks for your question and suggestion. I tested with Centos and Debian,  and it will not break if we just add -lstdc++ to the {unix, _} case. I change accordingly. Could you please check again?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org