[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1275: gremlin-javascript: remove session close method

[GitBox <gi...@apache.org>]

jorgebay commented on a change in pull request #1275: gremlin-javascript: remove session close method
URL: https://github.com/apache/tinkerpop/pull/1275#discussion_r407413763
 
 

 ##########
 File path: gremlin-javascript/src/main/javascript/gremlin-javascript/test/helper.js
 ##########
 @@ -48,5 +48,5 @@ exports.getClient = function getClient(traversalSource) {
 };
 
 exports.getSessionClient = function getSessionClient(traversalSource) {
-  return new Client(serverUrl, { 'traversalSource': traversalSource, 'processor': 'session'});
-};
\ No newline at end of file
+  return new Client(serverUrl, { 'traversalSource': traversalSource, 'session': 'unique-string-id'});
 
 Review comment:
   NIT: For the tests, I would avoid using the same identifier for the session as the documentation. It may wrongly imply that `unique-string-id` means something.
   
   ```suggestion
     return new Client(serverUrl, { 'traversalSource': traversalSource, 'session': 'my-nodejs-session'});
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services