You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Brian Hulette (Jira)" <ji...@apache.org> on 2020/12/10 16:30:00 UTC

[jira] [Commented] (BEAM-11436) Nullness checks are excessive for test classes

    [ https://issues.apache.org/jira/browse/BEAM-11436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247352#comment-17247352 ] 

Brian Hulette commented on BEAM-11436:
--------------------------------------

[~kenn] WDYT about this?

I think we should either:
- Find a way to use the JUnit annotations in typetools (https://github.com/typetools/junit4), or
- Don't do nullness checks on test classes

> Nullness checks are excessive for test classes
> ----------------------------------------------
>
>                 Key: BEAM-11436
>                 URL: https://issues.apache.org/jira/browse/BEAM-11436
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Brian Hulette
>            Priority: P2
>
> We don't have checkerframework nullness annotations for JUnit, which often leads to difficult nullness errors. The most onerous is that assertNotNull requires the argument to be NonNull already.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)