You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/04/10 12:34:32 UTC
Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
Fixed `rmdir.hpp` Windows build breaks.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
Diff: https://reviews.apache.org/r/45987/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/
-----------------------------------------------------------
(Updated April 14, 2016, 8:38 p.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
Fixed `rmdir.hpp` Windows build breaks.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
Diff: https://reviews.apache.org/r/45987/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/
-----------------------------------------------------------
(Updated April 14, 2016, 1:37 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Repository: mesos
Description
-------
Fixed `rmdir.hpp` Windows build breaks.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
Diff: https://reviews.apache.org/r/45987/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128036
-----------------------------------------------------------
Patch looks great!
Reviews applied: [45898, 44090, 45888, 45940, 44081, 44082, 44978, 44084, 45009, 45015, 45022, 44142, 45987]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 10, 2016, 10:34 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 10:34 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed `rmdir.hpp` Windows build breaks.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
> 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
>
> Diff: https://reviews.apache.org/r/45987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128564
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On April 10, 2016, 10:34 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 10:34 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed `rmdir.hpp` Windows build breaks.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
> 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
>
> Diff: https://reviews.apache.org/r/45987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
Posted by Alex Clemmer <cl...@gmail.com>.
> On April 12, 2016, 2:41 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 179
> > <https://reviews.apache.org/r/45987/diff/1/?file=1338480#file1338480line179>
> >
> > Can you explain why this is not defined on windows?
Well, I don't know how to port it to Windows. It is not clear to me that `rdev` or `mknod` make much sense to Windows. You might be able to make a totally different test that makes this work, but after spending an hour or two on it I decided that it is more important to make progress on other issues instead.
Thoughts? Do you think it is important to port it right now?
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128411
-----------------------------------------------------------
On April 10, 2016, 10:34 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 10:34 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed `rmdir.hpp` Windows build breaks.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
> 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
>
> Diff: https://reviews.apache.org/r/45987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On April 12, 2016, 2:41 p.m., Joris Van Remoortere wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 179
> > <https://reviews.apache.org/r/45987/diff/1/?file=1338480#file1338480line179>
> >
> > Can you explain why this is not defined on windows?
>
> Alex Clemmer wrote:
> Well, I don't know how to port it to Windows. It is not clear to me that `rdev` or `mknod` make much sense to Windows. You might be able to make a totally different test that makes this work, but after spending an hour or two on it I decided that it is more important to make progress on other issues instead.
>
> Thoughts? Do you think it is important to port it right now?
I meant can you add a comment explaining exactly what you just said in this review ;-)
Feel free to make it concise.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128411
-----------------------------------------------------------
On April 14, 2016, 1:37 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> -----------------------------------------------------------
>
> (Updated April 14, 2016, 1:37 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed `rmdir.hpp` Windows build breaks.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
> 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
>
> Diff: https://reviews.apache.org/r/45987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45987/#review128411
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp (line 80)
<https://reviews.apache.org/r/45987/#comment191833>
2 spaces for expression continuation.
3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp (line 176)
<https://reviews.apache.org/r/45987/#comment191834>
Can you explain why this is not defined on windows?
- Joris Van Remoortere
On April 10, 2016, 10:34 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45987/
> -----------------------------------------------------------
>
> (Updated April 10, 2016, 10:34 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed `rmdir.hpp` Windows build breaks.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp dd5cc6923ecc503d58e56128cf4ae736d8145fd7
> 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp cc92953ccc53f37c54b87e738b16ea1fb521b987
>
> Diff: https://reviews.apache.org/r/45987/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>