You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/01 04:43:46 UTC

[GitHub] [airflow] mik-laj opened a new pull request #13419: Fix environment checking for Pinot

mik-laj opened a new pull request #13419:
URL: https://github.com/apache/airflow/pull/13419


   In some cases, the validation of the environment may fail and end with the message below. 
   ```
     /opt/airflow/scripts/in_container/check_environment.sh: line 41: -H 'accept: text/plain' | grep OK: syntax error: invalid arithmetic operator (error token is "'accept: text/plain' | grep OK")
     Presto (Broker API): .-----------------------------------------------------------------------------------------------
   ```
   Unfortunately, Bash is not very obvious when it comes to multi-line text, and there is no type validation, so problems like this can happen.
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #13419: Fix environment checking for Pinot

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13419:
URL: https://github.com/apache/airflow/pull/13419


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #13419: Fix environment checking for Pinot

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13419:
URL: https://github.com/apache/airflow/pull/13419#issuecomment-753256298


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org