[GitHub] wido commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group

[GitBox <gi...@apache.org>]

wido commented on a change in pull request #2418: CLOUDSTACK-10242: Properly parse incoming rules to Sec Group
URL: https://github.com/apache/cloudstack/pull/2418#discussion_r162882114
 
 

 ##########
 File path: scripts/vm/network/security_group.py
 ##########
 @@ -951,16 +951,15 @@ def parse_network_rules(rules):
   if rules is None or len(rules) == 0:
     return ret
 
-  lines = rules.split(';')[:-1]
+  lines = rules.split('NEXT;')[:-1]
 
 Review comment:
   <pre>I:icmp;-1;-1;0.0.0.0/0,NEXT;I:tcp;0;65535;0.0.0.0/0,NEXT;I:udp;0;65535;0.0.0.0/0,NEXT;</pre>
   
   Sure, this is how it looks like. The NEXT word is the last word before a new rule/line starts

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services