You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/10/04 08:12:29 UTC

[I] [Bug] Four destructive actions fire on a single click or confirm without naming their target [rocketmq-dashboard]

tju-yxq opened a new issue, #5557:
URL: https://github.com/apache/rocketmq-dashboard/issues/5557

   ## Problem
   
   Four destructive or high-impact operations can be triggered with a single misclick, or confirmed without knowing which target they will hit:
   
   1. **Proxy config hot-reload** (`studio/Proxy.tsx`) — the per-row reload button is an icon-only `type="link"` button, visually identical to the harmless view-config gear next to it. One click hot-reloads that proxy's configuration with no confirmation at all — while the sibling remove-address action in the same row does have a named Popconfirm, and the proxy restart on the cluster page confirms with the address named.
   
   2. **Clear acknowledged alerts** (`ops/systemAlerts.tsx`) — the header button permanently deletes **every** acknowledged system alert record, yet it is styled as a plain default button (next to harmless export/maintenance buttons), states no count, and fires immediately on click.
   
   3. **NameServer address delete** (`studio/Ops.tsx`) — the delete Popconfirm says only the generic `您确定要删除吗?` ("Are you sure to delete?") without naming **which** address is selected, and the delete button sits beside the Select that holds the target — with several addresses configured, confirming the wrong one is easy.
   
   4. **Bulk enable/disable alert rules** (`ops/alerts.tsx`) — the two plain buttons silently enable or disable all selected rules on click. The sibling bulk-delete in the same toolbar confirms with a count; a misclick on "Disable Selected" stops N monitors with zero friction.
   
   ## Expected behavior
   
   - The proxy reload asks for confirmation naming the address (matching the remove-address and broker-restart pattern).
   - Clearing acknowledged alerts confirms what will be deleted and that it cannot be undone, with a danger-styled button and danger OK.
   - The NameServer delete confirm names the selected address.
   - Bulk enable/disable confirms with the selected count, like the sibling bulk delete.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Four destructive actions fire on a single click or confirm without naming their target [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #5557:
URL: https://github.com/apache/rocketmq-dashboard/issues/5557#issuecomment-6115548157

   This issue has been automatically closed because there has been no activity for 7 days. If you believe this issue is still relevant, please reopen it with updated information.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Bug] Four destructive actions fire on a single click or confirm without naming their target [rocketmq-dashboard]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed issue #5557: [Bug] Four destructive actions fire on a single click or confirm without naming their target
URL: https://github.com/apache/rocketmq-dashboard/issues/5557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org