You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/04/30 20:12:53 UTC
[jira] Created: (THRIFT-768) Async client for Java
Async client for Java
---------------------
Key: THRIFT-768
URL: https://issues.apache.org/jira/browse/THRIFT-768
Project: Thrift
Issue Type: Sub-task
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-768) Async client for Java
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-768.
--------------------------------
Fix Version/s: 0.4
Resolution: Fixed
I just committed this. Thanks again to Ning Liang for all his hard work!
> Async client for Java
> ---------------------
>
> Key: THRIFT-768
> URL: https://issues.apache.org/jira/browse/THRIFT-768
> Project: Thrift
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.4
>
> Attachments: thrift-768-v2.patch, thrift-768-v3.patch, thrift-768-v4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-768) Async client for Java
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-768:
---------------------------------
Attachment: thrift-768-v3.patch
Here's a more polished version. This renames a few things, does some refactoring, and just generally cleans things up.
> Async client for Java
> ---------------------
>
> Key: THRIFT-768
> URL: https://issues.apache.org/jira/browse/THRIFT-768
> Project: Thrift
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-768-v2.patch, thrift-768-v3.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-768) Async client for Java
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862830#action_12862830 ]
Bryan Duxbury commented on THRIFT-768:
--------------------------------------
I'm thinking of doing something makes use of minor compiler changes to offer really smooth access, so I'm planning for it to go into trunk. Not only will it be asynchronous from the client perspective, it's going to support NIO. (We really want to head towards single-io-threadedness for one of our high performance applications.)
I'd love to see what you've done though - feel free to attach a patch.
> Async client for Java
> ---------------------
>
> Key: THRIFT-768
> URL: https://issues.apache.org/jira/browse/THRIFT-768
> Project: Thrift
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-768) Async client for Java
Posted by "Mathias Herberts (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862814#action_12862814 ]
Mathias Herberts commented on THRIFT-768:
-----------------------------------------
Is that something you want to include in the generated code or could it be a contrib?
I already have a few classes which I use to invoke Thrift services asynchronously via an executor, I'll contribute them with pleasure, even if they just cover specific use cases (methods that return a single struct).
> Async client for Java
> ---------------------
>
> Key: THRIFT-768
> URL: https://issues.apache.org/jira/browse/THRIFT-768
> Project: Thrift
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-768) Async client for Java
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-768:
---------------------------------
Attachment: thrift-768-v2.patch
Here's the first draft of this functionality. I made some incremental changes on top of what Ning Liang contributed, particularly support for void and oneway method calls, as well as a simple test suite. I think there's probably a bit more cleanup and refactoring to do, but what's attached is fully functional.
> Async client for Java
> ---------------------
>
> Key: THRIFT-768
> URL: https://issues.apache.org/jira/browse/THRIFT-768
> Project: Thrift
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-768-v2.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-768) Async client for Java
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-768:
---------------------------------
Attachment: thrift-768-v4.patch
OK, this version does away with the awkward and unnecessary separate callbacks for errors and results.
Unless anyone has any further objections, I'll commit this later today.
> Async client for Java
> ---------------------
>
> Key: THRIFT-768
> URL: https://issues.apache.org/jira/browse/THRIFT-768
> Project: Thrift
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-768-v2.patch, thrift-768-v3.patch, thrift-768-v4.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.