You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by db...@apache.org on 2011/09/21 23:28:17 UTC

svn commit: r1173874 - in /openejb/trunk/patched-libraries: openwebbeans-jsf-patched/ openwebbeans-jsf-patched/pom.xml pom.xml

Author: dblevins
Date: Wed Sep 21 21:28:17 2011
New Revision: 1173874

URL: http://svn.apache.org/viewvc?rev=1173874&view=rev
Log:
patched openwebbeans-jsf without the faces-config.xml

Added:
    openejb/trunk/patched-libraries/openwebbeans-jsf-patched/
    openejb/trunk/patched-libraries/openwebbeans-jsf-patched/pom.xml
Modified:
    openejb/trunk/patched-libraries/pom.xml

Added: openejb/trunk/patched-libraries/openwebbeans-jsf-patched/pom.xml
URL: http://svn.apache.org/viewvc/openejb/trunk/patched-libraries/openwebbeans-jsf-patched/pom.xml?rev=1173874&view=auto
==============================================================================
--- openejb/trunk/patched-libraries/openwebbeans-jsf-patched/pom.xml (added)
+++ openejb/trunk/patched-libraries/openwebbeans-jsf-patched/pom.xml Wed Sep 21 21:28:17 2011
@@ -0,0 +1,74 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+  <!--
+
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+  -->
+  <modelVersion>4.0.0</modelVersion>
+
+  <parent>
+    <groupId>org.apache.openejb.patch</groupId>
+    <artifactId>openejb-patch-parent</artifactId>
+    <version>1.0-SNAPSHOT</version>
+  </parent>
+
+  <artifactId>openejb-openwebbeans-jsf</artifactId>
+  <version>1.2-SNAPSHOT</version>
+  <name>Apache OpenEJB Patch :: OpenWebBeans JSF</name>
+
+  <dependencies>
+    <dependency>
+      <groupId>org.apache.openwebbeans</groupId>
+      <artifactId>openwebbeans-jsf</artifactId>
+      <version>1.1.1</version>
+      <scope>provided</scope>
+    </dependency>
+  </dependencies>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-dependency-plugin</artifactId>
+        <version>2.3</version>
+        <executions>
+          <execution>
+            <id>patch</id>
+            <phase>process-classes</phase>
+            <goals>
+              <goal>unpack</goal>
+            </goals>
+            <configuration>
+              <excludes>META-INF/faces-config.xml</excludes>
+              <artifactItems>
+                <artifactItem>
+                  <groupId>org.apache.openwebbeans</groupId>
+                  <artifactId>openwebbeans-jsf</artifactId>
+                  <overWrite>false</overWrite>
+                  <outputDirectory>${project.build.outputDirectory}</outputDirectory>
+                </artifactItem>
+              </artifactItems>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+
+  <properties>
+    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+  </properties>
+</project>

Modified: openejb/trunk/patched-libraries/pom.xml
URL: http://svn.apache.org/viewvc/openejb/trunk/patched-libraries/pom.xml?rev=1173874&r1=1173873&r2=1173874&view=diff
==============================================================================
--- openejb/trunk/patched-libraries/pom.xml (original)
+++ openejb/trunk/patched-libraries/pom.xml Wed Sep 21 21:28:17 2011
@@ -39,6 +39,7 @@
   <modules>
     <module>bval-patched</module>
     <module>jstl-patched</module>
+    <module>openwebbeans-jsf-patched</module>
   </modules>
 
   <build>



Re: svn commit: r1173874 - in /openejb/trunk/patched-libraries: openwebbeans-jsf-patched/ openwebbeans-jsf-patched/pom.xml pom.xml

Posted by David Blevins <da...@gmail.com>.
On Sep 22, 2011, at 3:53 AM, Jacek Laskowski wrote:

> On Wed, Sep 21, 2011 at 11:28 PM,  <db...@apache.org> wrote:
>> Author: dblevins
>> Date: Wed Sep 21 21:28:17 2011
>> New Revision: 1173874
>> 
>> URL: http://svn.apache.org/viewvc?rev=1173874&view=rev
>> Log:
>> patched openwebbeans-jsf without the faces-config.xml
> 
> Why do we need it?

Some functionality of the OWB supplied faces-config.xml breaks the TCK in some situations.  Specifically the unconditional wrapping of the faces Application and ExpressionFactory objects.  We swap it out for something nearly identical, but with the tweak that it can be turned on and shut off without having to physically remove/add the jar from the classpath.

I don't suspect we'll need it very long and can move the change into OWB in some non-objectable fashion.


-David




Re: svn commit: r1173874 - in /openejb/trunk/patched-libraries: openwebbeans-jsf-patched/ openwebbeans-jsf-patched/pom.xml pom.xml

Posted by Jacek Laskowski <ja...@japila.pl>.
On Wed, Sep 21, 2011 at 11:28 PM,  <db...@apache.org> wrote:
> Author: dblevins
> Date: Wed Sep 21 21:28:17 2011
> New Revision: 1173874
>
> URL: http://svn.apache.org/viewvc?rev=1173874&view=rev
> Log:
> patched openwebbeans-jsf without the faces-config.xml

Why do we need it?

Jacek

-- 
Jacek Laskowski
Java EE, functional languages and IBM WebSphere - http://blog.japila.pl
Warszawa JUG conference = Confitura (formerly Javarsovia) :: http://confitura.pl