You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/06/06 09:09:38 UTC

[GitHub] [maven-shared-utils] mthmulders removed a comment on issue #7: [MSHARED-826] Require Java 7

mthmulders removed a comment on issue #7: [MSHARED-826] Require Java 7
URL: https://github.com/apache/maven-shared-utils/pull/7#issuecomment-499358493
 
 
   > The OS related tests need to be changed
   
   I assume this is also the case on master? Since this PR doesn't touch a single test... 
   
   But regardless of that, it'll be hard to fix those tests without touching Os.java itself. Its Javadoc says that it got copied over from Apache ANT. It appears to me that today in ANT, this class has the same testability issues as it has in Maven.
   
   So what do we want to do? Refactor the class to make it easier to test? Or accept that test coverage drops?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services