You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/04 12:11:53 UTC
[GitHub] [lucene-solr] mocobeta opened a new pull request #1946: LUCENE-9558: Clean up package name conflicts for analyzers-icu.
mocobeta opened a new pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946
See https://issues.apache.org/jira/browse/LUCENE-9558
- move classes under "o.a.l.collation" to "o.a.l.a.icu"
- classes under "o.a.l.collation.tokenattributes" to "o.a.l.a.icu.tokenattributes"
- delete "o.a.l.collation" from analyzers-icu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] msokolov commented on pull request #1946: LUCENE-9558: Clean up package name conflicts for analyzers-icu.
Posted by GitBox <gi...@apache.org>.
msokolov commented on pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946#issuecomment-703265901
I guess you got Robert's +1; the naming seems more sensible now to me, and we do it as part of major version upgrade.
BTW I stumbled on this split-package javadoc issue trying to add some utilities in lucene/misc/src/java/org/apache/lucene/util/hnsw - I guess I won't do that, but I wonder where benchmarking tools for hnsw belong? I guess we can put in core, analogous to what we did with tools over in analysis/kuromoji (where we moved DictBuilder from src/tools into src/java)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on pull request #1946: LUCENE-9558: Clean up package name conflicts for analyzers-icu.
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946#issuecomment-703493569
> BTW I stumbled on this split-package javadoc issue trying to add some utilities in lucene/misc/src/java/org/apache/lucene/util/hnsw - I guess I won't do that, but I wonder where benchmarking tools for hnsw belong?
Not pretty sure, but we could put benchmarking tools in lucene/benchmark?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta edited a comment on pull request #1946: LUCENE-9558: Clean up package name conflicts for analyzers-icu.
Posted by GitBox <gi...@apache.org>.
mocobeta edited a comment on pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946#issuecomment-703493569
> BTW I stumbled on this split-package javadoc issue trying to add some utilities in lucene/misc/src/java/org/apache/lucene/util/hnsw - I guess I won't do that, but I wonder where benchmarking tools for hnsw belong?
Not pretty sure, but we could put benchmarking tools in lucene/benchmark? I think package name would not be a big matter for it, maybe `o.a.l.benchmark.hnsw` would be ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta merged pull request #1946: LUCENE-9558: Clean up package name conflicts for analyzers-icu.
Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #1946:
URL: https://github.com/apache/lucene-solr/pull/1946
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org