You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/10/29 10:48:51 UTC

[GitHub] [incubator-shardingsphere] KomachiSion opened a new issue #3384: Implement DataSourcePropertiesSetter by SPI

KomachiSion opened a new issue #3384: Implement DataSourcePropertiesSetter by SPI
URL: https://github.com/apache/incubator-shardingsphere/issues/3384
 
 
   Some of connection pools can set custom datasource properties in spring, like HikariCP, see #3365 .
   Now, setting datasource properties of HikariCP for sharding-jdbc-spring has already implemented.
   But there are many of connection pools which can set datasource properties by their own ways.
   
   So I think ShardingSphere should implement DataSourcePropertiesSetter by SPI, make the feature can be expanded easier.
   
   - [x] Abstract DataSourcePropertiesSetter to SPI
   - [x] Support frequent connetion poll in sharding-jdbc-spring
        - [x] DBCP2
   - [ ] Support frequent connetion poll in sharding-jdbc-orchestration-spring
        - [ ] HikariCP
        - [ ] DBCP2
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services