[GitHub] [apisix] spacewander commented on a change in pull request #1979: bugfix: empty `allow_admin` means that any IP is allowed to access Ad…

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #1979:
URL: https://github.com/apache/apisix/pull/1979#discussion_r502904442



##########
File path: .travis/apisix_cli_test.sh
##########
@@ -211,8 +211,40 @@ fi
 
 echo "passed: worker_shutdown_timeout in nginx.conf is ok"
 
+# empty allow_admin in conf/config.yaml
+
+echo "
+apisix:
+    allow_admin:
+        - 127.0.0.9
+" > conf/config.yaml
+
+make init
+
+count=`grep -c "allow 127.0.0.9" conf/nginx.conf`
+if [ $count -eq 0 ]; then
+    echo "failed: not found 'allow 127.0.0.9;' in conf/nginx.conf"
+    exit 1
+fi
+
+echo "
+apisix:
+    allow_admin: ~
+" > conf/config.yaml
+
+make init
+
+count=`grep -c "allow all;" conf/nginx.conf || true`

Review comment:
       Look like the `|| true` doesn't take effect?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org