You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/05 09:56:36 UTC
[GitHub] [cordova-electron] erisu opened a new pull request #179: breaking(dependencies): bump electron, electron-builder & execa
erisu opened a new pull request #179:
URL: https://github.com/apache/cordova-electron/pull/179
### Motivation and Context
Use latest dependencies:
* Bump Dependencies
* electron@11.1.1
* electron-build@^22.9.1
* execa@^5.0.0
* Electron is pinned for builds 11.1.1
#### Electron 11.x (11.1.1)
Since Cordova-Electron 2.x is using Electron 10.1.2, there has been various fixes, security patches, new features and one breaking change introduced though all the version up to Electron 11.1.1.
Below I have outlined the main changes, but for a full list please review Electon's Change Log at: https://www.electronjs.org/releases/stable
##### Stack Upgrade
* Chromium 87.0.4280.47
* Node v12.18.3
* V8 v8.7
##### Breaking Changes
* Removed experimental APIs: BrowserView.{destroy, fromId, fromWebContents, getAllViews} and the id property of BrowserView.
#### Execa Breaking Change
* Removed the faulty emulated ENOENT error on Windows. https://github.com/sindresorhus/execa/releases/tag/v5.0.0
### Testing
- `npm t`
### Checklist
- [x] I've run the tests to see all new and existing tests pass
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-io commented on pull request #179: breaking(dependencies): bump electron, electron-builder & execa
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #179:
URL: https://github.com/apache/cordova-electron/pull/179#issuecomment-754547422
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=h1) Report
> Merging [#179](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=desc) (ba7d8e6) into [master](https://codecov.io/gh/apache/cordova-electron/commit/60a8cf1866bf34b10baa912e0aa065f84e1e8083?el=desc) (60a8cf1) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-electron/pull/179/graphs/tree.svg?width=650&height=150&src=pr&token=gnoel3CVuB)](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 652 652
=========================================
Hits 652 652
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=footer). Last update [60a8cf1...ba7d8e6](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] erisu merged pull request #179: breaking(dependencies): bump electron, electron-builder & execa
Posted by GitBox <gi...@apache.org>.
erisu merged pull request #179:
URL: https://github.com/apache/cordova-electron/pull/179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-electron] codecov-io edited a comment on pull request #179: breaking(dependencies): bump electron, electron-builder & execa
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #179:
URL: https://github.com/apache/cordova-electron/pull/179#issuecomment-754547422
# [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=h1) Report
> Merging [#179](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=desc) (ba7d8e6) into [master](https://codecov.io/gh/apache/cordova-electron/commit/60a8cf1866bf34b10baa912e0aa065f84e1e8083?el=desc) (60a8cf1) will **not change** coverage.
> The diff coverage is `n/a`.
[![Impacted file tree graph](https://codecov.io/gh/apache/cordova-electron/pull/179/graphs/tree.svg?width=650&height=150&src=pr&token=gnoel3CVuB)](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 652 652
=========================================
Hits 652 652
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=footer). Last update [60a8cf1...ba7d8e6](https://codecov.io/gh/apache/cordova-electron/pull/179?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org