You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/05/28 12:02:35 UTC
Review Request 70731: Refactored no guarantee resources allocation
logic in the 1st stage.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70731/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Refactored no guarantee resources allocation logic in the 1st stage.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 40c8363afddccdd5275ca06318a8cc2cc6fa21af
Diff: https://reviews.apache.org/r/70731/diff/1/
Testing
-------
make check
Optimized build benchmark result using `QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5`
shows no performance change.
Thanks,
Meng Zhu
Re: Review Request 70731: Refactored no guarantee resources
allocation logic in the 1st stage.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70731/#review215549
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On May 28, 2019, 12:02 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70731/
> -----------------------------------------------------------
>
> (Updated May 28, 2019, 12:02 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored no guarantee resources allocation logic in the 1st stage.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 40c8363afddccdd5275ca06318a8cc2cc6fa21af
>
>
> Diff: https://reviews.apache.org/r/70731/diff/1/
>
>
> Testing
> -------
>
> make check
>
> Optimized build benchmark result using `QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5`
> shows no performance change.
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70731: Refactored no guarantee resources
allocation logic in the 1st stage.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70731/#review215534
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70705, 70706, 70707, 70713, 70716, 70730, 70731]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 28, 2019, 12:02 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70731/
> -----------------------------------------------------------
>
> (Updated May 28, 2019, 12:02 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored no guarantee resources allocation logic in the 1st stage.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 40c8363afddccdd5275ca06318a8cc2cc6fa21af
>
>
> Diff: https://reviews.apache.org/r/70731/diff/1/
>
>
> Testing
> -------
>
> make check
>
> Optimized build benchmark result using `QuotaParam/BENCHMARK_HierarchicalAllocator_WithQuotaParam.LargeAndSmallQuota/5`
> shows no performance change.
>
>
> Thanks,
>
> Meng Zhu
>
>