You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by danny0405 <gi...@git.apache.org> on 2018/01/22 10:14:10 UTC

[GitHub] storm pull request #2522: [STORM-2901] Reuse ZK connection for getKeySequenc...

GitHub user danny0405 opened a pull request:

    https://github.com/apache/storm/pull/2522

    [STORM-2901] Reuse ZK connection for getKeySequenceNumber [for 2.0.0 storm]

    Reuse connections for nimbus blob-store keys registration when restarting.
    
    Also for storm-code setup.
    
    This is the JIRA: [#STORM-2901](https://issues.apache.org/jira/browse/STORM-2901)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/danny0405/storm reuse-zk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2522
    
----
commit c10bb03ecdf8fbee834124419d0368429f3f1919
Author: chenyuzhao <ch...@...>
Date:   2018-01-22T10:12:15Z

    reuse ZK for STORM-2901

----


---

[GitHub] storm issue #2522: [STORM-2901] Reuse ZK connection for getKeySequenceNumber...

Posted by HeartSaVioR <gi...@git.apache.org>.

Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2522
  
    @danny0405 
    Could you change your commit title to include issue number as well? Like `STORM-2901: Reuse ZK connection for Nimbus` given that we modified more than getKeySequenceNumber.
    
    You can `git commit --amend` to modify your previous commit, and `git push --force` to update your PR.
    
    Please let me know after you update. Thanks in advance!


---

[GitHub] storm pull request #2522: [STORM-2901] Reuse ZK connection for getKeySequenc...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2522


---

[GitHub] storm issue #2522: [STORM-2901] Reuse ZK connection for getKeySequenceNumber...

Posted by danny0405 <gi...@git.apache.org>.

Github user danny0405 commented on the issue:

    https://github.com/apache/storm/pull/2522
  
    @HeartSaVioR 
    Done.


---

[GitHub] storm issue #2522: [STORM-2901] Reuse ZK connection for getKeySequenceNumber...

Posted by danny0405 <gi...@git.apache.org>.

Github user danny0405 commented on the issue:

    https://github.com/apache/storm/pull/2522
  
    @HeartSaVioR 
    I have fire a bug issue ticket here: [#STORM-2905](https://issues.apache.org/jira/browse/STORM-2905)


---