You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "clebertsuconic (via GitHub)" <gi...@apache.org> on 2024/02/01 18:25:23 UTC
[PR] ARTEMIS-4617 upgrade JLine to 3.25.1 [activemq-artemis]
clebertsuconic opened a new pull request, #4800:
URL: https://github.com/apache/activemq-artemis/pull/4800
I had to remove the indirect dependency between the maven plugin and jline to avoid the maven plugin to parse some classes in jline that require experimental features on the JDK even when they are not in use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4617 upgrade JLine to 3.25.1 [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic merged PR #4800:
URL: https://github.com/apache/activemq-artemis/pull/4800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4617 upgrade JLine to 3.25.1 [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4800:
URL: https://github.com/apache/activemq-artemis/pull/4800#issuecomment-1924401580
this was previously discussed here: https://github.com/apache/activemq-artemis/pull/4790
this PR superseded #4790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4617 upgrade JLine to 3.25.1 [activemq-artemis]
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on PR #4800:
URL: https://github.com/apache/activemq-artemis/pull/4800#issuecomment-1921988461
According to [this](https://github.com/jline/jline3?tab=readme-ov-file#jansi) Jansi should be integrated into 3.25.x so we should be able to get ride of the Jansi dependency now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4617 upgrade JLine to 3.25.1 [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4800:
URL: https://github.com/apache/activemq-artemis/pull/4800#issuecomment-1922065403
@jbertram ohh.. jansi.. I think I reverted one change by accident... I will try to remove it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4617 upgrade JLine to 3.25.1 [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on code in PR #4800:
URL: https://github.com/apache/activemq-artemis/pull/4800#discussion_r1475089865
##########
artemis-distribution/pom.xml:
##########
@@ -157,6 +157,16 @@
<version>${project.version}</version>
</dependency>
+ <!-- shell integration -->
Review Comment:
I don't need this any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] ARTEMIS-4617 upgrade JLine to 3.25.1 [activemq-artemis]
Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #4800:
URL: https://github.com/apache/activemq-artemis/pull/4800#issuecomment-1922151537
Jansi removed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org