[GitHub] [spark] pan3793 commented on a diff in pull request #41725: [SPARK-44180][SQL] DistributionAndOrderingUtils should apply ResolveTimeZone

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #41725:
URL: https://github.com/apache/spark/pull/41725#discussion_r1261017441


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DistributionAndOrderingUtils.scala:
##########
@@ -83,13 +83,17 @@ object DistributionAndOrderingUtils {
         queryWithDistribution
       }
 
-      // Apply typeCoercionRules since the converted expression from TransformExpression
-      // implemented ImplicitCastInputTypes
-      typeCoercionRules.foldLeft(queryWithDistributionAndOrdering)((plan, rule) => rule(plan))
+      ResolveTimezoneAndCastExecutor.execute(queryWithDistributionAndOrdering)

Review Comment:
   I am not sure I fully understand the question.
   
   The `TimeZoneAwareExpression` may come from the implicitly Cast(see the case in the PR description), not only the v2 function construction(which I think I can control how to construct the expression and set timezone explicitly).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org