[GitHub] MaxGekk commented on a change in pull request #23811: [SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType

[GitBox <gi...@apache.org>]

MaxGekk commented on a change in pull request #23811: [SPARK-26902][SQL] Support java.time.Instant as an external type of TimestampType
URL: https://github.com/apache/spark/pull/23811#discussion_r257514044
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1659,6 +1659,12 @@ object SQLConf {
         "a SparkConf entry.")
       .booleanConf
       .createWithDefault(true)
+
+  val TIMESTAMP_EXTERNAL_TYPE = buildConf("spark.sql.catalyst.timestampType")
 
 Review comment:
   > We can support reading from both types at the same time right?
   
   At Spark side, we can read both.
   
   > I don't know if it's worth changing what it is written to; not worth a flag IMHO.
   
   Timestamps can be loaded from a datasource, casted from other types and etc. If an user wants to imports (collect) non-legacy timestamps (I mean `java.time.Instant`), how she/he can do that without the flag?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org