You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/12/14 22:41:01 UTC
Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting
public keys into a NetVie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54761/
-----------------------------------------------------------
Review request for geode, Galen O'Sullivan and Udo Kohlmeyer.
Bugs: GEODE-2215
https://issues.apache.org/jira/browse/GEODE-2215
Repository: geode
Description
-------
NetView creates a ConcurrentHashmap to hold the public keys when it's constructed but it had some methods that were replacing it with a Hashmap. I made the field final and also added checks to avoid putting a null key or value into the map.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java ca62e203985c19068554ff740f6e3d893ebd50a2
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/NetViewJUnitTest.java 715da474393cbfdd430cc5d54011c8a7739f6aee
Diff: https://reviews.apache.org/r/54761/diff/
Testing
-------
precheckin
Thanks,
Bruce Schuchardt
Re: Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting
public keys into a NetVie
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54761/#review159319
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java (lines 608 - 610)
<https://reviews.apache.org/r/54761/#comment230295>
Do we maybe not want to clear the previous entries before putAll? Do we want to keep all previous entries?
- Udo Kohlmeyer
On Dec. 14, 2016, 10:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54761/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 10:41 p.m.)
>
>
> Review request for geode, Galen O'Sullivan and Udo Kohlmeyer.
>
>
> Bugs: GEODE-2215
> https://issues.apache.org/jira/browse/GEODE-2215
>
>
> Repository: geode
>
>
> Description
> -------
>
> NetView creates a ConcurrentHashmap to hold the public keys when it's constructed but it had some methods that were replacing it with a Hashmap. I made the field final and also added checks to avoid putting a null key or value into the map.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java ca62e203985c19068554ff740f6e3d893ebd50a2
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/NetViewJUnitTest.java 715da474393cbfdd430cc5d54011c8a7739f6aee
>
> Diff: https://reviews.apache.org/r/54761/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting
public keys into a NetView
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54761/
-----------------------------------------------------------
(Updated Dec. 19, 2016, 5:05 p.m.)
Review request for geode, Galen O'Sullivan and Udo Kohlmeyer.
Summary (updated)
-----------------
GEODE-2215 NPE in ViewCreator thread setting public keys into a NetView
Bugs: GEODE-2215
https://issues.apache.org/jira/browse/GEODE-2215
Repository: geode
Description
-------
NetView creates a ConcurrentHashmap to hold the public keys when it's constructed but it had some methods that were replacing it with a Hashmap. I made the field final and also added checks to avoid putting a null key or value into the map.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java ca62e203985c19068554ff740f6e3d893ebd50a2
geode-core/src/test/java/org/apache/geode/distributed/internal/membership/NetViewJUnitTest.java 715da474393cbfdd430cc5d54011c8a7739f6aee
Diff: https://reviews.apache.org/r/54761/diff/
Testing
-------
precheckin
Thanks,
Bruce Schuchardt
Re: Review Request 54761: GEODE-2215 NPE in ViewCreator thread setting
public keys into a NetVie
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54761/#review159320
-----------------------------------------------------------
Ship it!
Other than the issue raised, ship it
- Udo Kohlmeyer
On Dec. 14, 2016, 10:41 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54761/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2016, 10:41 p.m.)
>
>
> Review request for geode, Galen O'Sullivan and Udo Kohlmeyer.
>
>
> Bugs: GEODE-2215
> https://issues.apache.org/jira/browse/GEODE-2215
>
>
> Repository: geode
>
>
> Description
> -------
>
> NetView creates a ConcurrentHashmap to hold the public keys when it's constructed but it had some methods that were replacing it with a Hashmap. I made the field final and also added checks to avoid putting a null key or value into the map.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/NetView.java ca62e203985c19068554ff740f6e3d893ebd50a2
> geode-core/src/test/java/org/apache/geode/distributed/internal/membership/NetViewJUnitTest.java 715da474393cbfdd430cc5d54011c8a7739f6aee
>
> Diff: https://reviews.apache.org/r/54761/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Bruce Schuchardt
>
>