You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/10/27 00:51:01 UTC

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11809


Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................

IMPALA-7614: [DOCS] Document the New Invalidate Options

--invalidate_tables_timeout_s
--invalidate_tables_on_memory_pressure

Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
---
M docs/topics/impala_config_options.xml
1 file changed, 35 insertions(+), 34 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/11809/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Adrian Ng (Code Review)" <ge...@cloudera.org>.
Adrian Ng has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml@367
PS2, Line 367:  is high 
We can say "reaches 60% of JVM heap size" to be specific.


http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml@368
PS2, Line 368: certain
We can say invalidates 10% of the least recently used tables.



-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 01:14:59 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:49:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/122/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Oct 2018 00:59:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11809/1/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/1/docs/topics/impala_config_options.xml@356
PS1, Line 356: invalidate
> invalidates
Done


http://gerrit.cloudera.org:8080/#/c/11809/1/docs/topics/impala_config_options.xml@366
PS1, Line 366: When
             :           the size of the garbage collection of <codeph>catalogd</codeph>
             :           exceeds a certain threshold, Impala invalidates a certain fraction of
             :           the least recently used tables. 
> "size of the garbage collection" isn't accurate, how about:
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:48:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/122/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Oct 2018 00:51:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................

IMPALA-7614: [DOCS] Document the New Invalidate Options

--invalidate_tables_timeout_s
--invalidate_tables_on_memory_pressure

Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Reviewed-on: http://gerrit.cloudera.org:8080/11809
Reviewed-by: Tianyi Wang <tw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_config_options.xml
1 file changed, 35 insertions(+), 34 deletions(-)

Approvals:
  Tianyi Wang: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 1:

Tiany and Adrian,
Could you please review for the coming release? 
Let me know if I should add any other reviewers.
Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Oct 2018 22:12:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Tianyi Wang, Adrian Ng, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11809

to look at the new patch set (#2).

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................

IMPALA-7614: [DOCS] Document the New Invalidate Options

--invalidate_tables_timeout_s
--invalidate_tables_on_memory_pressure

Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
---
M docs/topics/impala_config_options.xml
1 file changed, 35 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/11809/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Adrian Ng (Code Review)" <ge...@cloudera.org>.
Adrian Ng has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@363
PS3, Line 363: specified time period. T
in seconds.



-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 01:23:54 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/126/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:59:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/126/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:48:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11809/1/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/1/docs/topics/impala_config_options.xml@356
PS1, Line 356: invalidate
invalidates


http://gerrit.cloudera.org:8080/#/c/11809/1/docs/topics/impala_config_options.xml@366
PS1, Line 366: When
             :           the size of the garbage collection of <codeph>catalogd</codeph>
             :           exceeds a certain threshold, Impala invalidates a certain fraction of
             :           the least recently used tables. 
"size of the garbage collection" isn't accurate, how about:
"When the memory pressure is high after a Java garbage collection in catalogd, Impala invalidates ... "



-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 00:42:31 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@355
PS3, Line 355: small
bounded


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@365
PS3, Line 365: Java garbage collection-based 
simplify to: Memory-based


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@373
PS3, Line 373: but the feature could potentially
             :         cause performance risks
do we have standardized phrasing around memory knobs? something like, "may require tuning".



-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 05:57:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7614: [DOCS] Document the New Invalidate Options

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11809 )

Change subject: IMPALA-7614: [DOCS] Document the New Invalidate Options
......................................................................


Patch Set 2:

(6 comments)

This patch was merged with Tiany's +2, so I am uploading a new patch with the updates requested by Adrian and Vuk.

http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml@367
PS2, Line 367:  is high 
> We can say "reaches 60% of JVM heap size" to be specific.
Done


http://gerrit.cloudera.org:8080/#/c/11809/2/docs/topics/impala_config_options.xml@368
PS2, Line 368: certain
> We can say invalidates 10% of the least recently used tables.
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:

http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@355
PS3, Line 355: small
> bounded
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@363
PS3, Line 363: specified time period. T
> in seconds.
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@365
PS3, Line 365: Java garbage collection-based 
> simplify to: Memory-based
Done


http://gerrit.cloudera.org:8080/#/c/11809/3/docs/topics/impala_config_options.xml@373
PS3, Line 373: but the feature could potentially
             :         cause performance risks
> do we have standardized phrasing around memory knobs? something like, "may 
Changed to: the feature could potentially cause performance issues and may require tuning.



-- 
To view, visit http://gerrit.cloudera.org:8080/11809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I40c552eeaee81ee6528d9f725bd416b51d8ab837
Gerrit-Change-Number: 11809
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adrian Ng (389)
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Oct 2018 18:46:37 +0000
Gerrit-HasComments: Yes